Skip to content

sherlock: fix build#403611

Merged
pbsds merged 1 commit intoNixOS:masterfrom
dtomvan:fix-sherlock
May 2, 2025
Merged

sherlock: fix build#403611
pbsds merged 1 commit intoNixOS:masterfrom
dtomvan:fix-sherlock

Conversation

@dtomvan
Copy link
Contributor

@dtomvan dtomvan commented May 2, 2025

Removes the poetry dependency in nativeCheckInputs, as poetry-core
suffices. poetry has 4 tests failing right now, which is the next thing I'll
take a look at.

Hydra build: https://hydra.nixos.org/build/295980258

ZHF: #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review rev HEAD


x86_64-linux

✅ 6 packages built:
  • dialect
  • lambdabot
  • lambdabot.data
  • lambdabot.doc
  • sherlock
  • sherlock.dist

Add a 👍 reaction to pull requests you find important.

@dtomvan dtomvan added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 2, 2025
@nix-owners nix-owners bot requested a review from applePrincess May 2, 2025 12:42
@dtomvan

This comment was marked as off-topic.

@pbsbot
Copy link

pbsbot commented May 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403611


x86_64-linux

✅ 2 packages built:
  • sherlock
  • sherlock.dist

@pbsds pbsds merged commit 3d8c602 into NixOS:master May 2, 2025
50 of 52 checks passed
@dtomvan dtomvan deleted the fix-sherlock branch May 2, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants