Skip to content

qemu_xen: unbreak, add missing deps#403483

Closed
pbsds wants to merge 1 commit intoNixOS:masterfrom
pbsds:fix-qemu_xen-1746137399
Closed

qemu_xen: unbreak, add missing deps#403483
pbsds wants to merge 1 commit intoNixOS:masterfrom
pbsds:fix-qemu_xen-1746137399

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented May 1, 2025

fixes https://hydra.nixos.org/build/295921651
zhf #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review May 1, 2025 22:52
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 1, 2025
@pbsds pbsds closed this May 1, 2025
@SigmaSquadron
Copy link
Contributor

GitHub confuses and frightens me sometimes. Sorry for the accidental deletion; here's the original comment:

I've attempted this through an alternative means here: #403479.

I also wanted to add in a review comment the following:

I'd hate for qemu_xen to be the only one with fixes regarding libepoxy, especially since Xen doesn't care about X11 or GL at all!

If propagating the inputs isn't the way to go, then I'd rather have qemu_xen built with minimal = true, but I'm unsure if we'd be leaving something out that Xen depends on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants