Skip to content

pgadmin: use new yarn-berry_3 fetcher#402519

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
gador:pgadmin-new-yarn
May 4, 2025
Merged

pgadmin: use new yarn-berry_3 fetcher#402519
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
gador:pgadmin-new-yarn

Conversation

@gador
Copy link
Member

@gador gador commented Apr 28, 2025

Uses new yarn fetcher. See #399404

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 28, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5431

@yuyuyureka
Copy link
Contributor

yuyuyureka commented Apr 29, 2025

Would be nice if you added me to the co-authors. Or rather, if you're copying most of the contents from one of my commits, cherry-pick and amend to it.

@gador gador force-pushed the pgadmin-new-yarn branch from 06086e4 to e94008d Compare April 30, 2025 05:57
@gador
Copy link
Member Author

gador commented Apr 30, 2025

Would be nice if you added me to the co-authors. Or rather, if you're copying most of the contents from one of my commits, cherry-pick and amend to it.

Sure! Since I had to do some modifications, I just added you as Co-author instead of cherry-picking

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Co-authored-by: Yureka <yureka@cyberchaos.dev>
@gador gador force-pushed the pgadmin-new-yarn branch from e94008d to f3cef73 Compare April 30, 2025 06:55
@SuperSandro2000
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 402519


x86_64-linux

✅ 4 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist

@SuperSandro2000 SuperSandro2000 merged commit 8ddddcd into NixOS:master May 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants