Skip to content

electron{-source,-bin,-chromedriver}: updates#401697

Merged
yuyuyureka merged 8 commits intoNixOS:masterfrom
yayayayaka:electron-updates
Apr 30, 2025
Merged

electron{-source,-bin,-chromedriver}: updates#401697
yuyuyureka merged 8 commits intoNixOS:masterfrom
yayayayaka:electron-updates

Conversation

@yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented Apr 25, 2025 •
edited
Loading

Electron 33

Electron 34

Electron 35

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 25, 2025
@teutat3s
Copy link
Member

teutat3s commented Apr 28, 2025

Oh just saw this. Feel free to cherry-pick my electron_33-bin bump commit in #402553, then let's use yours.

@teutat3s teutat3s mentioned this pull request Apr 28, 2025
Closed
13 tasks
yayayayaka and others added 8 commits April 29, 2025 11:26
@yayayayaka
electron-source.electron_34: 34.5.2 -> 34.5.3
1fabde7 
- Changelog: https://github.com/electron/electron/releases/tag/v34.5.3
- Diff: electron/electron@refs/tags/v34.5.2...v34.5.3
@yayayayaka
electron-source.electron_35: 35.2.0 -> 35.2.1
d90cf06 
- Changelog: https://github.com/electron/electron/releases/tag/v35.2.1
- Diff: electron/electron@refs/tags/v35.2.0...v35.2.1
@yayayayaka
electron_34-bin: 34.5.2 -> 34.5.3
87eb7e1 
- Changelog: https://github.com/electron/electron/releases/tag/v34.5.3
- Diff: electron/electron@refs/tags/v34.5.2...v34.5.3
@yayayayaka
electron-chromedriver_34: 34.5.2 -> 34.5.3
67d92ac 
- Changelog: https://github.com/electron/electron/releases/tag/v34.5.3
- Diff: electron/electron@refs/tags/v34.5.2...v34.5.3
@yayayayaka
electron_35-bin: 35.2.0 -> 35.2.1
6d95b05 
- Changelog: https://github.com/electron/electron/releases/tag/v35.2.1
- Diff: electron/electron@refs/tags/v35.2.0...v35.2.1
@yayayayaka
electron-chromedriver_35: 35.2.0 -> 35.2.1
e688610 
- Changelog: https://github.com/electron/electron/releases/tag/v35.2.1
- Diff: electron/electron@refs/tags/v35.2.0...v35.2.1
@teutat3s @yayayayaka
electron-chromedriver_33: 33.4.10 -> 33.4.11
75f7632 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.11
- Diff: electron/electron@refs/tags/v33.4.10...v33.4.11
@teutat3s @yayayayaka
electron_33-bin: 33.4.10 -> 33.4.11
a1d2d82 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.11
- Diff: electron/electron@refs/tags/v33.4.10...v33.4.11
@teutat3s
Copy link
Member

teutat3s commented Apr 30, 2025

Building electron_35 on aarch64-linux ...

@teutat3s
Copy link
Member

teutat3s commented Apr 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401697

aarch64-linux

✅ 3 packages built:
  • electron-chromedriver_35
  • electron_35
  • electron_35-bin

@teutat3s
Copy link
Member

teutat3s commented Apr 30, 2025

Building electron_34 on aarch64-linux ...

@teutat3s
Copy link
Member

teutat3s commented Apr 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401697

aarch64-linux

✅ 3 packages built:
  • electron-chromedriver_34
  • electron_34
  • electron_34-bin

@teutat3s teutat3s added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 30, 2025
@yuyuyureka yuyuyureka merged commit 58072cb into NixOS:master Apr 30, 2025
36 of 38 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 30, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Apr 30, 2025
Merged
1 task
@yayayayaka yayayayaka deleted the electron-updates branch May 6, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s teutat3s approved these changes

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

@yuyuyureka yuyuyureka Awaiting requested review from yuyuyureka

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yayayayaka @teutat3s @yuyuyureka