Skip to content

linux_xanmod, linux_xanmod_latest: add update script#401636

Merged
alyssais merged 1 commit intoNixOS:masterfrom
eljamm:xanmod/update-script
Jul 29, 2025
Merged

linux_xanmod, linux_xanmod_latest: add update script#401636
alyssais merged 1 commit intoNixOS:masterfrom
eljamm:xanmod/update-script

Conversation

@eljamm
Copy link
Contributor

@eljamm eljamm commented Apr 25, 2025

To test, run:

nix-shell maintainers/scripts/update.nix --argstr package linux_xanmod

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 25, 2025
@eljamm eljamm force-pushed the xanmod/update-script branch from f11812e to fc4f180 Compare April 25, 2025 05:48
@eljamm
Copy link
Contributor Author

eljamm commented Apr 25, 2025

I've noticed that passthru.updateScript doesn't propagate to linux_xanmod and linux_xanmod_latest, but this is the case for all kernels, not just Xanmod (which needs to be added to manual-config.nix and I already had some success doing so).

So to test this, one would just need to run:

  • ./update-xanmod.sh <VARIANT> from the same directory as the file, or
  • pkgs/os-specific/linux/kernel/update-xanmod.sh <VARIANT>

@zzzsyyy
Copy link
Member

zzzsyyy commented Apr 25, 2025

Seems that the filename is sometimes <variant>/<version>-xanmod**2**?(it's relatively rare)

@eljamm eljamm force-pushed the xanmod/update-script branch from fc4f180 to bfb5898 Compare April 25, 2025 09:05
@eljamm
Copy link
Contributor Author

eljamm commented Apr 25, 2025

Seems that the filename is sometimes <variant>/<version>-xanmod**2**?(it's relatively rare)

Interesting, I didn't know that. Nice catch!

@eljamm eljamm force-pushed the xanmod/update-script branch from bfb5898 to 441d64e Compare April 25, 2025 15:52
@eljamm
Copy link
Contributor Author

eljamm commented Apr 25, 2025

New changes:

  • Small refactors
  • Add some comments to clarify what this does
  • Properly handle and update the suffix

@eljamm eljamm force-pushed the xanmod/update-script branch 2 times, most recently from d1427ab to 2d4d5aa Compare April 25, 2025 17:22
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5430

@eljamm eljamm force-pushed the xanmod/update-script branch from a81e9b3 to 6a6f46e Compare May 6, 2025 07:02
@eljamm eljamm force-pushed the xanmod/update-script branch 2 times, most recently from e78e9be to c3ec8b3 Compare June 15, 2025 09:13
@eljamm
Copy link
Contributor Author

eljamm commented Jun 15, 2025

Since #412568 has been merged, this can now be tested with:

nix-shell maintainers/scripts/update.nix --argstr package linux_xanmod

@eljamm eljamm requested a review from zzzsyyy June 15, 2025 09:16
Co-authored-by: Mathias Zhang <me@zzzsy.top>
@eljamm eljamm force-pushed the xanmod/update-script branch from c3ec8b3 to 6c33201 Compare July 29, 2025 07:14
@nix-owners nix-owners bot requested a review from K900 July 29, 2025 07:16
@eljamm
Copy link
Contributor Author

eljamm commented Jul 29, 2025

I've been using this since April without any issues, so I think this is good to merge, but any suggestions are welcome.

@alyssais alyssais merged commit 6f2ad75 into NixOS:master Jul 29, 2025
26 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jul 29, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 29, 2025
@eljamm eljamm deleted the xanmod/update-script branch July 29, 2025 16:31
@eljamm
Copy link
Contributor Author

eljamm commented Jul 29, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants