Skip to content

yarn-berry.yarn-berry-fetcher: 1.0.0 -> 1.0.1#401631

Merged
flokli merged 2 commits intoNixOS:masterfrom
yuyuyureka:berry-fetcher-fixes
Apr 25, 2025
Merged

yarn-berry.yarn-berry-fetcher: 1.0.0 -> 1.0.1#401631
flokli merged 2 commits intoNixOS:masterfrom
yuyuyureka:berry-fetcher-fixes

Conversation

@yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Apr 25, 2025

Things done

This new tag contains several improvements:

  • The tgz fetcher (used for npm registry) will now retry downloads 5 times before giving up
  • The error messages are improved and refer to the manual
  • The behavior in the case where optional dependencies are included in a cache with a compression level ("10c0") is fixed: their filenames should include the "c0"

Additionally, we implement the suggestion from @TomaSajt to disable fixupPhase, since it might accidentally patch shebangs on executable scripts in git checkouts.

Tested that the following attributes still build and their outputHash stays the same:

  • ipydatagrid.offlineCache
  • hedgedoc.offlineCache
  • grafana.offlineCache

We can confirm that any package that was successfully packaged would still have the same hash, but #397639 should be able to proceed to Link phase now.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yuyuyureka yuyuyureka requested review from TomaSajt and flokli April 25, 2025 04:32
@yuyuyureka yuyuyureka marked this pull request as ready for review April 25, 2025 04:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 25, 2025
@flokli flokli merged commit 4ea6e8a into NixOS:master Apr 25, 2025
60 of 63 checks passed
@yuyuyureka yuyuyureka deleted the berry-fetcher-fixes branch April 25, 2025 09:22
@TomaSajt
Copy link
Contributor

Thanks for the quick fix!

A link with the diff of the changes would be welcome in future PRs,
something like this: https://cyberchaos.dev/yuka/yarn-berry-fetcher/-/compare/1.0.0...1.0.1

@yuyuyureka
Copy link
Contributor Author

A link like that is included in the commit message ;)

@TomaSajt
Copy link
Contributor

I seem to always forget about multiline commit messages... (both to read, and to write)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants