yarn-berry.yarn-berry-fetcher: 1.0.0 -> 1.0.1#401631
Merged
flokli merged 2 commits intoNixOS:masterfrom Apr 25, 2025
Merged
Conversation
This was referenced Apr 25, 2025
Contributor
|
Thanks for the quick fix! A link with the diff of the changes would be welcome in future PRs, |
Contributor
Author
|
A link like that is included in the commit message ;) |
Contributor
|
I seem to always forget about multiline commit messages... (both to read, and to write) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
This new tag contains several improvements:
Additionally, we implement the suggestion from @TomaSajt to disable fixupPhase, since it might accidentally patch shebangs on executable scripts in git checkouts.
Tested that the following attributes still build and their outputHash stays the same:
We can confirm that any package that was successfully packaged would still have the same hash, but #397639 should be able to proceed to Link phase now.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.