Skip to content

boost187: Fix ABI detection for empty 'os.platform'#401486

Merged
wegank merged 1 commit intoNixOS:stagingfrom
Aleksanaa:boost1
May 4, 2025
Merged

boost187: Fix ABI detection for empty 'os.platform'#401486
wegank merged 1 commit intoNixOS:stagingfrom
Aleksanaa:boost1

Conversation

@Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Apr 24, 2025 •
edited by wegank
Loading

This fixes build of boost (make it really usable) on loongarch64, and potentially other platforms not listed in os.platform.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • loongarch64-linux
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 24, 2025
@nix-owners nix-owners bot requested a review from hjones2199 April 24, 2025 16:13
@Aleksanaa Aleksanaa added the 6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs label Apr 25, 2025
@Aleksanaa Aleksanaa requested a review from vcunat April 26, 2025 04:15
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 26, 2025
@wegank
Copy link
Member

wegank commented Apr 29, 2025

When building nixVersions.nix_2_28 I'm getting the same link failures about jump_fcontext as in #181160. Is there a solution? Probably by applying a similar fix?

@Aleksanaa
Copy link
Member Author

Aleksanaa commented Apr 29, 2025

When building nixVersions.nix_2_28 I'm getting the same link failures about jump_fcontext as in #181160. Is there a solution? Probably by applying a similar fix?

My commit should fix the same problem as your commit, see original patch

@wegank wegank merged commit 62f3fe9 into NixOS:staging May 4, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@hjones2199 hjones2199 Awaiting requested review from hjones2199

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

6.topic: loongarch64 LoongArch, a new RISC ISA used on Loongson CPUs 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aleksanaa @wegank