Skip to content

telepathy-logger: revert drop#401149

Closed
LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
LordGrimmauld:telepathy-logger-readd
Closed

telepathy-logger: revert drop#401149
LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
LordGrimmauld:telepathy-logger-readd

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Apr 23, 2025

Partial revert of #400308
Reverts #400329
Includes #384284
Part of #388196

Judging by #400308 (comment), people are still using telepathy-logger and it shouldn't have been removed.

I kept the fix commit as authored by @poly2it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 23, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@LordGrimmauld LordGrimmauld marked this pull request as draft April 23, 2025 15:36
@Sigmanificient
Copy link
Member

Is this ready for review?

@LordGrimmauld
Copy link
Contributor Author

Is this ready for review?

#400308 (comment)
#400308 (comment)

As pointed out by @jtojnar , the uses that i seemingly missed (= loaded dynamically without a specifically declared package dependency) are in fact not actually present anymore. Therefore it is questionable whether this is actually needed. Until anyone has an actual declared need for telepathy-logger it should stay gone. If anyone has an actual need, i'll undraft this.

@nyabinary
Copy link
Contributor

Doesn't seem to be causing any problems. Should this be closed?

@LordGrimmauld
Copy link
Contributor Author

Thanks, probably unnecessary indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants