telepathy-logger: revert drop#401149
Closed
LordGrimmauld wants to merge 3 commits intoNixOS:masterfrom
Closed
Conversation
13 tasks
Member
|
Is this ready for review? |
Contributor
Author
#400308 (comment) As pointed out by @jtojnar , the uses that i seemingly missed (= loaded dynamically without a specifically declared package dependency) are in fact not actually present anymore. Therefore it is questionable whether this is actually needed. Until anyone has an actual declared need for |
Contributor
|
Doesn't seem to be causing any problems. Should this be closed? |
Contributor
Author
|
Thanks, probably unnecessary indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #400308
Reverts #400329
Includes #384284
Part of #388196
Judging by #400308 (comment), people are still using
telepathy-loggerand it shouldn't have been removed.I kept the fix commit as authored by @poly2it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.