Skip to content

furnace: fix deps after SDL2 migration#400902

Merged
OPNA2608 merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-unyvswmnxxto
Apr 23, 2025
Merged

furnace: fix deps after SDL2 migration#400902
OPNA2608 merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-unyvswmnxxto

Conversation

@marcin-serwin
Copy link
Contributor

libGL is no longer propagated by SDL2, see #393386

fixes #400899

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@nix-owners nix-owners bot requested a review from OPNA2608 April 22, 2025 18:44
@marcin-serwin marcin-serwin changed the title furnace: add missing libGL dependency furnace: fix deps after SDL2 migration Apr 23, 2025
@marcin-serwin marcin-serwin requested a review from OPNA2608 April 23, 2025 15:38
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400902


aarch64-linux

✅ 1 package built:
  • furnace

LGTM.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 23, 2025
@OPNA2608 OPNA2608 merged commit a43704a into NixOS:master Apr 23, 2025
33 of 37 checks passed
@marcin-serwin marcin-serwin deleted the push-unyvswmnxxto branch May 5, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: furnace

2 participants