Skip to content

treewide: move to by-name#400547

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
0xda157:by-name
Apr 21, 2025
Merged

treewide: move to by-name#400547
Aleksanaa merged 1 commit intoNixOS:masterfrom
0xda157:by-name

Conversation

@0xda157
Copy link
Contributor

@0xda157 0xda157 commented Apr 21, 2025

using https://github.com/Aleksanaa/by-name-migrate, pretty sure most of these are because of #398707

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2025
@Aleksanaa
Copy link
Member

pretty sure most of these are because of #398707

No, it's still in staging now. You can rerun it when it hits master (as I would like to minimize potential merge conflicts when merged into master)

@Aleksanaa Aleksanaa merged commit 0292bfd into NixOS:master Apr 21, 2025
24 of 27 checks passed
@0xda157 0xda157 deleted the by-name branch April 21, 2025 16:53
@0xda157
Copy link
Contributor Author

0xda157 commented Apr 21, 2025

pretty sure most of these are because of #398707

No, it's still in staging now. You can rerun it when it hits master (as I would like to minimize potential merge conflicts when merged into master)

didn’t notice it was targeting staging, sounds good

@Aleksanaa
Copy link
Member

You can run the script again now 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants