Merged
Conversation
github-actions
bot
added
the
6.topic: python
github-actions
bot
added
10.rebuild-darwin: 11-100
Contributor
|
@GaetanLepage i remember you having issues with pygame on darwin, re pygame/pygame#4486 / #399467 While i don't expect this to fix itself, do you mind trying again with this PR? Probably won't work, but worth a shot. |
Contributor
Thanks for the heads up! |
LordGrimmauld
requested changes
Apr 20, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Some minor things, like putting an alias and messed up line ordering.
Thanks for working on this!
Contributor
There was a problem hiding this comment.
Suggested change
| ## Darwin headless will hang when trying to run the SDL test program | |
| enableSTB ? true, | |
| enableSTB ? true, | |
| ## Darwin headless will hang when trying to run the SDL test program |
This is confusing ordering
Contributor
There was a problem hiding this comment.
Thanks for dropping this! This should however get an entry in pkgs/top-level/aliases.nix
Comment on lines
43
to
44
Contributor
There was a problem hiding this comment.
While we are here: libXpm and giflib are being flagged by my nix-check-deps tool - are they actually required?
Contributor
Author
There was a problem hiding this comment.
I couldn't find any usage of them, removed.
marcin-serwin
force-pushed
the
push-mwqlmoqwwlvp
branch
from
0e3333f to
8a6d784
Compare
LordGrimmauld
approved these changes
Apr 20, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Diff looks good to me, running nixpkgs-review now
|
13 tasks
wegank
added
the
12.approvals: 1
Contributor
Author
|
All the failing packages also fail to build for me on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version was pinned due to
pygameandpygame-ce. It turns out that it was only due to the fact that newer versions changed defaults from libpng/libjpeg to STB backend. After adding the option to build the SDL2_image with these libs, both of them can be built with the newest version of SDL2_image.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.