Skip to content

treewide: remove incorrect duplicate libsoup dependencies#400316

Merged
drupol merged 4 commits intoNixOS:masterfrom
LordGrimmauld:soup-dedup
Apr 20, 2025
Merged

treewide: remove incorrect duplicate libsoup dependencies#400316
drupol merged 4 commits intoNixOS:masterfrom
LordGrimmauld:soup-dedup

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Apr 20, 2025

webkitgtk propagates the correct libsoup dependencies.
A package depending on both libsoup_2_4 and webkitgtk_4_1 is always incorrect, as webkitgtk propagates the (incompatible) libsoup_3.

Part of #398783

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld requested a review from jtojnar April 20, 2025 11:10
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2025
@nix-owners nix-owners bot requested review from a user, genga898 and redyf April 20, 2025 11:18
@LordGrimmauld
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400316


x86_64-linux

✅ 4 packages built:
  • aonsoku
  • neohtop
  • rclone-ui
  • yaak

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400316


aarch64-linux

✅ 3 packages built:
  • aonsoku
  • neohtop
  • rclone-ui

@LordGrimmauld LordGrimmauld changed the title treewide: remove icorrect duplicate libsoup dependencies treewide: remove incorrect duplicate libsoup dependencies Apr 20, 2025
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 20, 2025
@drupol drupol merged commit 8e01bc6 into NixOS:master Apr 20, 2025
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants