Skip to content

tree-wide: use stdenv.cc.libcxx instead of libcxx on Darwin #399882

Merged
emilazy merged 12 commits intoNixOS:masterfrom
reckenrode:push-mrmsnnxuwmzo
Apr 20, 2025
Merged

tree-wide: use stdenv.cc.libcxx instead of libcxx on Darwin #399882
emilazy merged 12 commits intoNixOS:masterfrom
reckenrode:push-mrmsnnxuwmzo

Conversation

@reckenrode
Copy link
Contributor

This was split off from #398727. It is primarily targeted at workarounds for the issue where Clang is invoked as clang, and it doesn’t include the C++ headers. These changes shouldn’t cause any rebuilds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 18, 2025
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: R R is a programming language for statistical computing and data visualization. labels Apr 18, 2025
@nix-owners nix-owners bot requested review from Profpatsch, jbedo and ulrikstrid April 18, 2025 23:17
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 18, 2025
@emilazy emilazy merged commit fb3adb1 into NixOS:master Apr 20, 2025
24 checks passed
@trofi
Copy link
Contributor

trofi commented Apr 22, 2025

stdenv.cc.libcxx is null on Linux. This causes minor eval failures when attributes evaluated there. Proposed a small tweak as:

@reckenrode reckenrode deleted the push-mrmsnnxuwmzo branch May 9, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: R R is a programming language for statistical computing and data visualization. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants