Skip to content

sm64ex: 0-unstable-2024-07-04 -> 0-unstable-2024-12-17, add missing libGL#399852

Merged
thiagokokada merged 2 commits intoNixOS:masterfrom
qubitnano:sm64ex
Apr 18, 2025
Merged

sm64ex: 0-unstable-2024-07-04 -> 0-unstable-2024-12-17, add missing libGL#399852
thiagokokada merged 2 commits intoNixOS:masterfrom
qubitnano:sm64ex

Conversation

@qubitnano
Copy link
Contributor

@qubitnano qubitnano commented Apr 18, 2025

Fixes #399793

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@qubitnano qubitnano added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: games Gaming on NixOS labels Apr 18, 2025
keenanweaver
keenanweaver approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick turnaround! Working as expected.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399852

x86_64-linux

✅ 1 package built:
  • sm64ex

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 18, 2025
@thiagokokada thiagokokada merged commit 1e0ba16 into NixOS:master Apr 18, 2025
26 of 30 checks passed
@qubitnano qubitnano deleted the sm64ex branch April 18, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

+1 more reviewer

@keenanweaver keenanweaver keenanweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: sm64ex

3 participants

@qubitnano @thiagokokada @keenanweaver