Skip to content

python312Packages.pygame: mark as broken on darwin #399467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaetanLepage merged 1 commit into from
Apr 17, 2025
Merged

python312Packages.pygame: mark as broken on darwin #399467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/development/python-modules/pygame/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,9 @@ buildPythonPackage rec {
license = lib.licenses.lgpl21Plus;
maintainers = with lib.maintainers; [ emilytrau ];
platforms = lib.platforms.unix;
badPlatforms = [
# Several tests segfault
lib.systems.inspect.patterns.isDarwin
];
Comment on lines +125 to +128
Copy link
Contributor

@doronbehar doronbehar Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the good ol' broken = stdenv.hostPlatform.isDarwin 😄 ?

Copy link
Contributor Author

@GaetanLepage GaetanLepage Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is functionally the same but provides a slightly more helpful error message. It is thus preferred AFAIK.

Copy link
Contributor

@doronbehar doronbehar Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference in error message?

};
}