Skip to content

wrkflw: init at v0.3.0#399316

Closed
linuxmobile wants to merge 1 commit intoNixOS:masterfrom
linuxmobile:wrkflw
Closed

wrkflw: init at v0.3.0#399316
linuxmobile wants to merge 1 commit intoNixOS:masterfrom
linuxmobile:wrkflw

Conversation

@linuxmobile
Copy link
Contributor

@linuxmobile linuxmobile commented Apr 16, 2025

Initial packaging of wrkflw, a GitHub Actions workflow validator and executor. Currently packaged from main branch as the project has no tagged releases.

The package provides a TUI-based interface for validating and executing GitHub Actions workflows locally, helping developers test their workflows before pushing to GitHub.

Tested on x86_64-linux.

image

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.

@linuxmobile linuxmobile mentioned this pull request Apr 16, 2025
Closed
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 16, 2025
0xda157
0xda157 suggested changes Apr 16, 2025
View reviewed changes
@linuxmobile linuxmobile changed the title wrkflw: init at unstable-2024-01-19 wrkflw: init at 0-unstable-2024-01-19 Apr 16, 2025
0xda157
0xda157 reviewed Apr 16, 2025
View reviewed changes
0xda157
0xda157 reviewed Apr 16, 2025
View reviewed changes
@linuxmobile linuxmobile changed the title wrkflw: init at 0-unstable-2024-01-19 wrkflw: init at 0-unstable-2024-04-14 Apr 16, 2025
@0xda157
Copy link
Contributor

0xda157 commented Apr 16, 2025

commit + pr should be renamed to match the version in the package

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 16, 2025

commit + pr should be renamed to match the version in the package

doesn't match?

@0xda157
Copy link
Contributor

0xda157 commented Apr 16, 2025

doesn't match?

2024 vs 2025

@linuxmobile linuxmobile changed the title wrkflw: init at 0-unstable-2024-04-14 wrkflw: init at 0-unstable-2025-04-14 Apr 16, 2025
@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 16, 2025

doesn't match?

2024 vs 2025

really sorry haha.

@0xda157 0xda157 added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 16, 2025
0xda157
0xda157 reviewed Apr 17, 2025
View reviewed changes
@FKouhai
Copy link
Member

FKouhai commented Apr 19, 2025 •
edited
Loading

Log

       last 25 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > shrinking /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw
       > checking for references to /build/ in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14...
       > patching script interpreter paths in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > stripping (with command strip and flags -S -p) in  /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin
       > Running phase: installCheckPhase
       > Executing versionCheckPhase
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --help
       > GitHub Workflow validator and executor
       >
       > Usage: wrkflw [OPTIONS] [COMMAND]
       >
       > Commands:
       >   validate  Validate GitHub workflow files
       >   run       Execute GitHub workflow files locally
       >   tui       Open TUI interface to manage workflows
       >   help      Print this message or the help of the given subcommand(s)
       >
       > Options:
       >   -v, --verbose  Run in verbose mode with detailed output
       >   -h, --help     Print help
       >   -V, --version  Print version
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --version
       > wrkflw 0.2.1
       For full logs, run:
         nix log /nix/store/i8rx7aq6dhq39g4jyg3lrxi10mkc5m39-wrkflw-0-unstable-2025-04-14.drv

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

❌ 1 package failed to build:
  • wrkflw

For some reason the version outlined is 0.2.1, although in the upstream repo I do not see any tag nor release with that version
edit:
The version is defined in the Cargo.toml file: https://github.com/bahdotsh/wrkflw/blob/fb65b6765439f1048d37f935d8527d419377a621/Cargo.toml#L3

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 19, 2025 •
edited
Loading

Log

       last 25 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > shrinking /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw
       > checking for references to /build/ in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14...
       > patching script interpreter paths in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > stripping (with command strip and flags -S -p) in  /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin
       > Running phase: installCheckPhase
       > Executing versionCheckPhase
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --help
       > GitHub Workflow validator and executor
       >
       > Usage: wrkflw [OPTIONS] [COMMAND]
       >
       > Commands:
       >   validate  Validate GitHub workflow files
       >   run       Execute GitHub workflow files locally
       >   tui       Open TUI interface to manage workflows
       >   help      Print this message or the help of the given subcommand(s)
       >
       > Options:
       >   -v, --verbose  Run in verbose mode with detailed output
       >   -h, --help     Print help
       >   -V, --version  Print version
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --version
       > wrkflw 0.2.1
       For full logs, run:
         nix log /nix/store/i8rx7aq6dhq39g4jyg3lrxi10mkc5m39-wrkflw-0-unstable-2025-04-14.drv

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

❌ 1 package failed to build:

For some reason the version outlined is 0.2.1, although in the upstream repo I do not see any tag nor release with that version edit: The version is defined in the Cargo.toml file: https://github.com/bahdotsh/wrkflw/blob/fb65b6765439f1048d37f935d8527d419377a621/Cargo.toml#L3

The build work fine, the issue can be related with the changes that @awwpotato request...

image
image

@FKouhai
Copy link
Member

FKouhai commented Apr 19, 2025

Log

       last 25 log lines:
       > Running phase: fixupPhase
       > shrinking RPATHs of ELF executables and libraries in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > shrinking /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw
       > checking for references to /build/ in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14...
       > patching script interpreter paths in /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14
       > stripping (with command strip and flags -S -p) in  /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin
       > Running phase: installCheckPhase
       > Executing versionCheckPhase
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --help
       > GitHub Workflow validator and executor
       >
       > Usage: wrkflw [OPTIONS] [COMMAND]
       >
       > Commands:
       >   validate  Validate GitHub workflow files
       >   run       Execute GitHub workflow files locally
       >   tui       Open TUI interface to manage workflows
       >   help      Print this message or the help of the given subcommand(s)
       >
       > Options:
       >   -v, --verbose  Run in verbose mode with detailed output
       >   -h, --help     Print help
       >   -V, --version  Print version
       > Did not find version 0-unstable-2025-04-14 in the output of the command /nix/store/4x97j3rqilmzilzalb0aa2s2z7wn3x7q-wrkflw-0-unstable-2025-04-14/bin/wrkflw --version
       > wrkflw 0.2.1
       For full logs, run:
         nix log /nix/store/i8rx7aq6dhq39g4jyg3lrxi10mkc5m39-wrkflw-0-unstable-2025-04-14.drv

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

❌ 1 package failed to build:
For some reason the version outlined is 0.2.1, although in the upstream repo I do not see any tag nor release with that version edit: The version is defined in the Cargo.toml file: https://github.com/bahdotsh/wrkflw/blob/fb65b6765439f1048d37f935d8527d419377a621/Cargo.toml#L3

The build work fine, the issue can be related with the changes that @awwpotato request...
Might be related to it, although it is a bit unconventional I'd advice updating the version to 0.2.1 instead of having the 0-unstable-2025-04-14, although I understand that would be a bit painful in the future to keep track of specially if the upstream maintainers never change the version and we keep using the 0-unstable naming for the versioning.

image image

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 19, 2025

Might be related to it, although it is a bit unconventional I'd advice updating the version to 0.2.1 instead of having the 0-unstable-2025-04-14, although I understand that would be a bit painful in the future to keep track of specially if the upstream maintainers never change the version and we keep using the 0-unstable naming for the versioning.

Clearly that was my main idea and that was how the PR was done, but the user @awwpotato suggested that I make those changes in order to get the PR approved. You can check all this in the changes he requested as resolved.

It doesn't make much sense to me either, because if you even check the PR, there is an open issue requiring the project creator to start working with releases (here the request).

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

✅ 1 package built:
  • wrkflw

@FKouhai
Copy link
Member

FKouhai commented Apr 19, 2025

oh I see, thanks for the extra context :)
if the upstream maintainer is going to work on releases/tags on their repo maybe you could already change the version to 0.2.1 and keep the version check/install check that way once it's ready it would be simpler for a maintainer that has write permissions to merge the PR

0xda157
0xda157 reviewed Apr 19, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the version outlined is 0.2.1, although in the upstream repo I do not see any tag nor release with that version
edit:
The version is defined in the Cargo.toml file: https://github.com/bahdotsh/wrkflw/blob/fb65b6765439f1048d37f935d8527d419377a621/Cargo.toml#L3

this package should probably be versioned as 0.2.1-unstable-2025-04-14 then

the issue can be related with the changes that @awwpotato request...

sorry abt that, doesn't make any since to versionCheck a program without a version

You can check all this in the changes he requested as resolved.

*she

@FKouhai
Copy link
Member

FKouhai commented Apr 20, 2025

another thing, you might probably want to add yourself as a maintainer on this package, im not totally sure new packages should be maintainer-less

@0xda157
Copy link
Contributor

0xda157 commented Apr 20, 2025

im not totally sure new packages should be maintainer-less

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes

meta.maintainers must be set for new packages.

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 20, 2025

should be maintainer-less

ok

0xda157
0xda157 approved these changes Apr 20, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FKouhai
Copy link
Member

FKouhai commented Apr 20, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

✅ 1 package built:
  • wrkflw
lgtm

@FKouhai FKouhai added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 20, 2025
@linuxmobile linuxmobile changed the title wrkflw: init at 0-unstable-2025-04-14 wrkflw: init at v0.3.0 Apr 21, 2025
@FKouhai
Copy link
Member

FKouhai commented Apr 21, 2025

could you add the version check again?

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Apr 21, 2025

could you add the version check again?

already tested and working 👍🏼

@FKouhai
Copy link
Member

FKouhai commented Apr 21, 2025

image

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

✅ 1 package built:
  • wrkflw

yep lgtm, thank you very much :)

@FKouhai FKouhai mentioned this pull request Apr 21, 2025
Open
13 tasks
0xda157
0xda157 suggested changes Apr 21, 2025
View reviewed changes
@0xda157
Copy link
Contributor

0xda157 commented Apr 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399316

x86_64-linux

✅ 1 package built:
  • wrkflw

@FKouhai FKouhai mentioned this pull request Apr 22, 2025
Closed
13 tasks
@0xda157 0xda157 mentioned this pull request Apr 22, 2025
Merged
13 tasks
@linuxmobile linuxmobile mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@FKouhai FKouhai FKouhai approved these changes

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linuxmobile @0xda157 @FKouhai