Skip to content

libchamplain: default to libsoup_3#399078

Closed
LordGrimmauld wants to merge 1 commit intoNixOS:libsoup-updatesfrom
LordGrimmauld:champlain-soup
Closed

libchamplain: default to libsoup_3#399078
LordGrimmauld wants to merge 1 commit intoNixOS:libsoup-updatesfrom
LordGrimmauld:champlain-soup

Conversation

@LordGrimmauld
Copy link
Contributor

Part of #398783 and #360897.

This default should be switched, now that we are trying to get rid of libsoup_2_4 wherever possible.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld changed the base branch from master to libsoup-updates April 16, 2025 06:08
@LordGrimmauld LordGrimmauld requested a review from jtojnar April 16, 2025 06:08
@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399078


aarch64-linux

❌ 1 package failed to build:
  • gpx-viewer
✅ 6 packages built:
  • geeqie
  • gthumb
  • libchamplain
  • libchamplain.dev
  • libchamplain.devdoc
  • lifeograph

@LordGrimmauld
Copy link
Contributor Author

gpx-viewer has a dep failure on gdl which fails on master due to Gcc14

@jtojnar
Copy link
Member

jtojnar commented Apr 16, 2025

Using just grep and looking at the found expressions, reverse dependencies depending on libsoup_2_4 version of libchamplain:

  • gthumb: leaf, uses webkitgtk_4_0 and libsoup_2_4, newer versions not supported, might need to disable webservices support.
  • lifeograph: leaf, no other obvious libsoup dependencies
  • gpx-viewer: leaf, no other obvious libsoup dependencies
  • geeqie: leaf, no other obvious libsoup dependencies

The last three should probably be fine to switch to libchamplain_libsoup3 on master, as it provides the same API.

Once all of these are migrated, libchamplain support for libsoup_2_4 can be dropped.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399078


x86_64-linux

❌ 1 package failed to build:
  • gpx-viewer
✅ 6 packages built:
  • geeqie
  • gthumb
  • libchamplain
  • libchamplain.dev
  • libchamplain.devdoc
  • lifeograph

@LordGrimmauld
Copy link
Contributor Author

Ah wait we do have a package for that? oops! My bad!

@LordGrimmauld LordGrimmauld marked this pull request as draft April 16, 2025 07:16
@alyssais alyssais deleted the branch NixOS:libsoup-updates April 26, 2025 15:59
@alyssais alyssais closed this Apr 26, 2025
@korrat korrat mentioned this pull request Jul 30, 2025
3 tasks
markus1189 added a commit to markus1189/nixpkgs that referenced this pull request Jul 30, 2025
The old libchamplain uses libsoup2 which prevents it from building due
to being marked as insecure, see NixOS#399078

Closes NixOS#429614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants