treewide: Remove use of apple_sdk framework stub paths

pkgs/by-name/gi/gildas/package.nix

@@ -12,7 +12,6 @@
   perl,
   groff,
   which,
-  darwin,
   ncurses,
 }:
 
@@ -49,17 +48,13 @@ stdenv.mkDerivation rec {
     which
   ];
 
-  buildInputs =
-    [
-      gtk2-x11
-      lesstif
-      cfitsio
-      python3Env
-      ncurses
-    ]
-    ++ lib.optionals stdenv.hostPlatform.isDarwin (
-      with darwin.apple_sdk.frameworks; [ CoreFoundation ]
-    );
+  buildInputs = [
+    gtk2-x11
+    lesstif
+    cfitsio
+    python3Env
+    ncurses
+  ];
 
   patches =
     [ ./wrapper.patch ]
@@ -73,10 +68,6 @@ stdenv.mkDerivation rec {
   # Workaround for https://github.com/NixOS/nixpkgs/issues/304528
   env.GAG_CPP = lib.optionalString stdenv.hostPlatform.isDarwin "${gfortran.outPath}/bin/cpp";
 
-  NIX_LDFLAGS = lib.optionalString stdenv.hostPlatform.isDarwin (
-    with darwin.apple_sdk.frameworks; "-F${CoreFoundation}/Library/Frameworks"
-  );
-
   configurePhase = ''
     substituteInPlace admin/wrapper.sh --replace '%%OUT%%' $out
     substituteInPlace admin/wrapper.sh --replace '%%PYTHONHOME%%' ${python3Env}

pkgs/by-name/od/odin/darwin-remove-impure-links.patch

@@ -0,0 +1,23 @@
+diff --git a/src/linker.cpp b/src/linker.cpp
+index ec165ef7d..91a28b8fc 100644
+--- a/src/linker.cpp
++++ b/src/linker.cpp
+@@ -769,18 +769,6 @@ try_cross_linking:;
+ 			gbString platform_lib_str = gb_string_make(heap_allocator(), "");
+ 			defer (gb_string_free(platform_lib_str));
+ 			if (build_context.metrics.os == TargetOs_darwin) {
+-				platform_lib_str = gb_string_appendc(platform_lib_str, "-Wl,-syslibroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -L/usr/local/lib ");
+-
+-				// Homebrew's default library path, checking if it exists to avoid linking warnings.
+-				if (gb_file_exists("/opt/homebrew/lib")) {
+-					platform_lib_str = gb_string_appendc(platform_lib_str, "-L/opt/homebrew/lib ");
+-				}
+-
+-				// MacPort's default library path, checking if it exists to avoid linking warnings.
+-				if (gb_file_exists("/opt/local/lib")) {
+-					platform_lib_str = gb_string_appendc(platform_lib_str, "-L/opt/local/lib ");
+-				}
+-
+ 				// Only specify this flag if the user has given a minimum version to target.
+ 				// This will cause warnings to show up for mismatched libraries.
+ 				if (build_context.minimum_os_version_string_given) {

pkgs/by-name/od/odin/package.nix

@@ -1,12 +1,9 @@
 {
   fetchFromGitHub,
   lib,
-  libiconv,
   llvmPackages,
-  MacOSX-SDK,
   makeBinaryWrapper,
   nix-update-script,
-  Security,
   which,
 }:
 
@@ -24,16 +21,9 @@ stdenv.mkDerivation {
     hash = "sha256-GXea4+OIFyAhTqmDh2q+ewTUqI92ikOsa2s83UH2r58=";
   };
 
-  postPatch =
-    lib.optionalString stdenv.hostPlatform.isDarwin ''
-      substituteInPlace src/linker.cpp \
-          --replace-fail '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk' ${MacOSX-SDK}
-    ''
-    + ''
-      substituteInPlace build_odin.sh \
-          --replace-fail '-framework System' '-lSystem'
-      patchShebangs build_odin.sh
-    '';
+  patches = [
+    ./darwin-remove-impure-links.patch
+  ];
 
   LLVM_CONFIG = "${llvmPackages.llvm.dev}/bin/llvm-config";
 
@@ -46,11 +36,6 @@ stdenv.mkDerivation {
     which
   ];
 
-  buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [
-    libiconv
-    Security
-  ];
-
   installPhase = ''
     runHook preInstall
 

pkgs/by-name/op/opensc/package.nix

@@ -14,9 +14,7 @@
   docbook_xsl,
   libxslt,
   docbook_xml_dtd_412,
-  darwin,
   nix-update-script,
-  withApplePCSC ? stdenv.hostPlatform.isDarwin,
 }:
 
 stdenv.mkDerivation rec {
@@ -35,46 +33,33 @@ stdenv.mkDerivation rec {
     autoreconfHook
     libxslt # xsltproc
   ];
-  buildInputs =
-    [
-      zlib
-      readline
-      openssl
-      libassuan
-      libXt
-      libiconv
-      docbook_xml_dtd_412
-    ]
-    ++ lib.optional stdenv.hostPlatform.isDarwin darwin.apple_sdk.frameworks.Carbon
-    ++ (if withApplePCSC then [ darwin.apple_sdk.frameworks.PCSC ] else [ pcsclite ]);
+  buildInputs = [
+    zlib
+    readline
+    openssl
+    libassuan
+    libXt
+    libiconv
+    docbook_xml_dtd_412
+  ] ++ lib.optional (!stdenv.hostPlatform.isDarwin) pcsclite;
 
   env.NIX_CFLAGS_COMPILE = "-Wno-error";
 
-  configureFlags = [
-    "--enable-zlib"
-    "--enable-readline"
-    "--enable-openssl"
-    "--enable-pcsc"
-    "--enable-sm"
-    "--enable-man"
-    "--enable-doc"
-    "--localstatedir=/var"
-    "--sysconfdir=/etc"
-    "--with-xsl-stylesheetsdir=${docbook_xsl}/xml/xsl/docbook"
-    "--with-pcsc-provider=${
-      if withApplePCSC then
-        "${darwin.apple_sdk.frameworks.PCSC}/Library/Frameworks/PCSC.framework/PCSC"
-      else
-        "${lib.getLib pcsclite}/lib/libpcsclite${stdenv.hostPlatform.extensions.sharedLibrary}"
-    }"
-  ];
-
-  PCSC_CFLAGS = lib.concatStringsSep " " (
-    lib.optionals withApplePCSC [
-      "-I${darwin.apple_sdk.frameworks.PCSC}/Library/Frameworks/PCSC.framework/Headers"
-      "-I${lib.getDev pcsclite}/include/PCSC"
+  configureFlags =
+    [
+      "--enable-zlib"
+      "--enable-readline"
+      "--enable-openssl"
+      "--enable-pcsc"
+      "--enable-sm"
+      "--enable-man"
+      "--enable-doc"
+      "--localstatedir=/var"
+      "--sysconfdir=/etc"
+      "--with-xsl-stylesheetsdir=${docbook_xsl}/xml/xsl/docbook"
     ]
-  );
+    ++ lib.optional (!stdenv.hostPlatform.isDarwin)
+      "--with-pcsc-provider=${lib.getLib pcsclite}/lib/libpcsclite${stdenv.hostPlatform.extensions.sharedLibrary}";
 
   installFlags = [
     "sysconfdir=$(out)/etc"

pkgs/development/libraries/bullet/default.nix

@@ -6,8 +6,6 @@
   libGLU,
   libGL,
   libglut,
-  Cocoa,
-  OpenGL,
 }:
 
 stdenv.mkDerivation rec {
@@ -22,26 +20,16 @@ stdenv.mkDerivation rec {
   };
 
   nativeBuildInputs = [ cmake ];
-  buildInputs =
-    lib.optionals stdenv.hostPlatform.isLinux [
-      libGLU
-      libGL
-      libglut
-    ]
-    ++ lib.optionals stdenv.hostPlatform.isDarwin [
-      Cocoa
-      OpenGL
-    ];
+  buildInputs = [
+    libGLU
+    libGL
+    libglut
+  ];
 
-  postPatch =
-    ''
-      substituteInPlace examples/ThirdPartyLibs/Gwen/CMakeLists.txt \
-        --replace "-DGLEW_STATIC" "-DGLEW_STATIC -Wno-narrowing"
-    ''
-    + lib.optionalString stdenv.hostPlatform.isDarwin ''
-      sed -i 's/FIND_PACKAGE(OpenGL)//' CMakeLists.txt
-      sed -i 's/FIND_LIBRARY(COCOA_LIBRARY Cocoa)//' CMakeLists.txt
-    '';
+  postPatch = ''
+    substituteInPlace examples/ThirdPartyLibs/Gwen/CMakeLists.txt \
+      --replace "-DGLEW_STATIC" "-DGLEW_STATIC -Wno-narrowing"
+  '';
 
   cmakeFlags =
     [
@@ -50,11 +38,6 @@ stdenv.mkDerivation rec {
       "-DINSTALL_EXTRA_LIBS=ON"
     ]
     ++ lib.optionals stdenv.hostPlatform.isDarwin [
-      "-DOPENGL_FOUND=true"
-      "-DOPENGL_LIBRARIES=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DOPENGL_gl_LIBRARY=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DCOCOA_LIBRARY=${Cocoa}/Library/Frameworks/Cocoa.framework"
       "-DBUILD_BULLET2_DEMOS=OFF"
       "-DBUILD_UNIT_TESTS=OFF"
       "-DBUILD_BULLET_ROBOTICS_GUI_EXTRA=OFF"

pkgs/development/libraries/bullet/roboschool-fork.nix

@@ -6,8 +6,6 @@
   libGLU,
   libGL,
   libglut,
-  Cocoa,
-  OpenGL,
 }:
 
 stdenv.mkDerivation {
@@ -26,36 +24,21 @@ stdenv.mkDerivation {
   };
 
   nativeBuildInputs = [ cmake ];
-  buildInputs =
-    lib.optionals stdenv.hostPlatform.isLinux [
-      libGLU
-      libGL
-      libglut
-    ]
-    ++ lib.optionals stdenv.hostPlatform.isDarwin [
-      Cocoa
-      OpenGL
-    ];
+  buildInputs = [
+    libGLU
+    libGL
+    libglut
+  ];
 
   patches = [ ./gwen-narrowing.patch ];
 
-  postPatch = lib.optionalString stdenv.hostPlatform.isDarwin ''
-    sed -i 's/FIND_PACKAGE(OpenGL)//' CMakeLists.txt
-    sed -i 's/FIND_LIBRARY(COCOA_LIBRARY Cocoa)//' CMakeLists.txt
-  '';
-
   cmakeFlags =
     [
       "-DBUILD_SHARED_LIBS=ON"
       "-DBUILD_CPU_DEMOS=OFF"
       "-DINSTALL_EXTRA_LIBS=ON"
     ]
     ++ lib.optionals stdenv.hostPlatform.isDarwin [
-      "-DOPENGL_FOUND=true"
-      "-DOPENGL_LIBRARIES=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DOPENGL_gl_LIBRARY=${OpenGL}/Library/Frameworks/OpenGL.framework"
-      "-DCOCOA_LIBRARY=${Cocoa}/Library/Frameworks/Cocoa.framework"
       "-DBUILD_BULLET2_DEMOS=OFF"
       "-DBUILD_UNIT_TESTS=OFF"
     ];

pkgs/development/libraries/libsamplerate/default.nix

@@ -4,15 +4,8 @@
   fetchurl,
   pkg-config,
   libsndfile,
-  ApplicationServices,
-  Carbon,
-  CoreServices,
 }:
 
-let
-  inherit (lib) optionals optionalString;
-
-in
 stdenv.mkDerivation rec {
   pname = "libsamplerate";
   version = "0.2.2";
@@ -23,12 +16,7 @@ stdenv.mkDerivation rec {
   };
 
   nativeBuildInputs = [ pkg-config ];
-  buildInputs =
-    [ libsndfile ]
-    ++ optionals stdenv.hostPlatform.isDarwin [
-      ApplicationServices
-      CoreServices
-    ];
+  buildInputs = [ libsndfile ];
 
   configureFlags = [ "--disable-fftw" ];
 
@@ -37,12 +25,6 @@ stdenv.mkDerivation rec {
     "out"
   ];
 
-  postConfigure = optionalString stdenv.hostPlatform.isDarwin ''
-    # need headers from the Carbon.framework in /System/Library/Frameworks to
-    # compile this on darwin -- not sure how to handle
-    NIX_CFLAGS_COMPILE+=" -I${Carbon}/Library/Frameworks/Carbon.framework/Headers"
-  '';
-
   meta = with lib; {
     description = "Sample Rate Converter for audio";
     homepage = "https://libsndfile.github.io/libsamplerate/";

pkgs/development/libraries/netcdf-fortran/default.nix

@@ -6,9 +6,6 @@
   hdf5,
   curl,
   gfortran,
-  CoreFoundation,
-  CoreServices,
-  SystemConfiguration,
 }:
 stdenv.mkDerivation rec {
   pname = "netcdf-fortran";
@@ -22,23 +19,12 @@ stdenv.mkDerivation rec {
   };
 
   nativeBuildInputs = [ gfortran ];
-  buildInputs =
-    [
-      netcdf
-      hdf5
-      curl
-    ]
-    ++ lib.optionals stdenv.hostPlatform.isDarwin [
-      CoreFoundation
-      CoreServices
-      SystemConfiguration
-    ];
-  env.NIX_LDFLAGS = toString (
-    lib.optionals stdenv.hostPlatform.isDarwin [
-      "-F${CoreServices}/Library/Frameworks"
-      "-F${SystemConfiguration}/Library/Frameworks"
-    ]
-  );
+  buildInputs = [
+    netcdf
+    hdf5
+    curl
+  ];
+
   doCheck = true;
 
   FFLAGS = [ "-std=legacy" ];