Skip to content

python3Packages.py3exiv2: fix build on Darwin#399005

Merged
phaer merged 1 commit intoNixOS:masterfrom
reckenrode:push-upsrwpkkmmyy
May 30, 2025
Merged

python3Packages.py3exiv2: fix build on Darwin#399005
phaer merged 1 commit intoNixOS:masterfrom
reckenrode:push-upsrwpkkmmyy

Conversation

@reckenrode
Copy link
Contributor

The package’s setup.py assumes Boost is in /usr/local/lib, which is incorrect in nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 15, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 15, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 17, 2025
@yzx9
Copy link
Contributor

yzx9 commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399005


aarch64-darwin

❌ 2 packages failed to build:
  • mediagoblin
  • mediagoblin.dist
✅ 6 packages built:
  • python312Packages.py3exiv2
  • python312Packages.py3exiv2.dist
  • python313Packages.py3exiv2
  • python313Packages.py3exiv2.dist
  • vimiv-qt
  • vimiv-qt.dist

Update: maybe not related, mediagoblin was broken by gst-python

The package’s `setup.py` assumes Boost is in `/usr/local/lib`, which is
incorrect in nixpkgs.
@reckenrode reckenrode force-pushed the push-upsrwpkkmmyy branch from b59c9d0 to 78ffe12 Compare May 30, 2025 00:19
@phaer phaer merged commit 058f7cf into NixOS:master May 30, 2025
16 of 17 checks passed
@reckenrode reckenrode deleted the push-upsrwpkkmmyy branch June 18, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants