Skip to content

treewide: update to webkitgtk_4_1 where possible#398999

Merged
alyssais merged 1 commit intoNixOS:libsoup-updatesfrom
LordGrimmauld:webkit-updates
Apr 22, 2025
Merged

treewide: update to webkitgtk_4_1 where possible#398999
alyssais merged 1 commit intoNixOS:libsoup-updatesfrom
LordGrimmauld:webkit-updates

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Apr 15, 2025

Methodology

  • sed to find and replace in pkgs/*
  • exclude pkgs/top-level
  • nixpkgs-review on x86_64-linux and aarch64-linux
  • revert everything that doesn't build
  • revert everything that doesn't launch [x86_64-linux]
  • check upstream source whether the change makes sense [free software only]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398999


aarch64-linux

✅ 40 packages built:
  • apvlv
  • badwolf
  • bespokesynth
  • bespokesynth-with-vst2
  • claws-mail
  • claws-mail.dev
  • dbeaver-bin
  • eclipses.eclipse-committers
  • eclipses.eclipse-cpp
  • eclipses.eclipse-dsl
  • eclipses.eclipse-embedcpp
  • eclipses.eclipse-java
  • eclipses.eclipse-jee
  • eclipses.eclipse-modeling
  • eclipses.eclipse-platform
  • eclipses.eclipse-rcp
  • eclipses.eclipse-sdk
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache
  • formiko
  • formiko.dist
  • giara
  • gp-saml-gui
  • gp-saml-gui.dist
  • juce
  • mihomo-party
  • nyxt
  • obs-studio-plugins.obs-webkitgtk
  • osmo
  • plugdata
  • rednotebook
  • rednotebook.dist
  • rnnoise-plugin
  • sbclPackages.cl-webkit2
  • socalabs-sid
  • ulauncher
  • ulauncher.dist
  • wasistlos
  • ysfx

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398999


x86_64-linux

✅ 51 packages built:
  • apache-directory-studio
  • apvlv
  • archi
  • badwolf
  • bespokesynth
  • bespokesynth-with-vst2
  • bitcomet
  • claws-mail
  • claws-mail.dev
  • dbeaver-bin
  • eclipse-mat
  • eclipses.eclipse-committers
  • eclipses.eclipse-cpp
  • eclipses.eclipse-dsl
  • eclipses.eclipse-embedcpp
  • eclipses.eclipse-java
  • eclipses.eclipse-jee
  • eclipses.eclipse-modeling
  • eclipses.eclipse-platform
  • eclipses.eclipse-rcp
  • eclipses.eclipse-sdk
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache
  • formiko
  • formiko.dist
  • giara
  • gp-saml-gui
  • gp-saml-gui.dist
  • juce
  • lutris
  • lutris-free
  • lutris-unwrapped
  • lutris-unwrapped.dist
  • mihomo-party
  • minigalaxy
  • minigalaxy.dist
  • nyxt
  • obs-studio-plugins.obs-webkitgtk
  • osmo
  • plugdata
  • portfolio
  • rednotebook
  • rednotebook.dist
  • rnnoise-plugin
  • sbclPackages.cl-webkit2
  • socalabs-sid
  • ulauncher
  • ulauncher.dist
  • wasistlos
  • ysfx

@LordGrimmauld
Copy link
Contributor Author

I removed badwolf from the list as that package was dropped on master.

@LordGrimmauld LordGrimmauld requested a review from jerith666 April 16, 2025 14:39
@LordGrimmauld
Copy link
Contributor Author

Pinged @jerith666 for review - they maintain eclipse, and many of the affected programs use the very same java gui framework.

@jerith666
Copy link
Contributor

A quick spot-check of a rebuilt eclipse on top of a cherry-pick of this commit shows that basic webkit functionality (browsing javadocs in pop-up windows) appears to work fine. Is there something more specific you were concerned about that warrants a deeper investigation before merging?

@LordGrimmauld
Copy link
Contributor Author

A quick spot-check of a rebuilt eclipse on top of a cherry-pick of this commit shows that basic webkit functionality (browsing javadocs in pop-up windows) appears to work fine. Is there something more specific you were concerned about that warrants a deeper investigation before merging?

The update should be fine on anything that still compiles and does not use webRTC functionality. I don't use eclipse anymore, personally, and that was one of the more popular packages in here so i wanted a maintainer to check.

@LordGrimmauld
Copy link
Contributor Author

I did check lutris, it uses webkitgtk for the login windows for the various game platforms. That does work.

Methodology:
- `sed` to find and replace in pkgs/*
- exclude pkgs/top-level
- nixpkgs-review on x86_64-linux and aarch64-linux
- revert everything that doesn't build
- revert everything that doesn't launch [x86_64-linux]
- check upstream source whether the change makes sense [free software only]
@LordGrimmauld
Copy link
Contributor Author

I just fixed two oversights (webkitgtk propagates correct libsoup, so unless explicitly depended upon it shouldn't be listed here). I also added the testing methodology used to the commit message.

To the best of my knowledge and ability, nothing should break from this, though if it does it can easily be reverted later.

@LordGrimmauld
Copy link
Contributor Author

@ofborg build formiko rednotebook lutris-unwrapped lutris nyxt obs-webkitgtk apache-directory-studio apvlv archi bespokesynth bitcomet claws-mail dbeaver-bin eclipse-mat ente-auth exaile giara mihomo-party minigalaxy osmo plugdata portfolio socalabs-sid ulauncher wasistlos rnnoise-plugin juce gp-saml-gui

Copy link
Contributor

@jerith666 jerith666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good to me. The eclipse derivation doesn't build from source, so testing basic functionality is definitely warranted there, but it seems fine -- thanks for checking!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 19, 2025
@LordGrimmauld
Copy link
Contributor Author

Not sure how to move this forward. Pinged getchoo (familiar with the tauri things) and Alyssa (who was very helpful before).

@alyssais alyssais merged commit cd062f0 into NixOS:libsoup-updates Apr 22, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants