treewide: update to webkitgtk_4_1 where possible#398999
treewide: update to webkitgtk_4_1 where possible#398999alyssais merged 1 commit intoNixOS:libsoup-updatesfrom
Conversation
|
|
0f8e346 to
a6132f2
Compare
|
I removed |
|
Pinged @jerith666 for review - they maintain eclipse, and many of the affected programs use the very same java gui framework. |
|
A quick spot-check of a rebuilt eclipse on top of a cherry-pick of this commit shows that basic webkit functionality (browsing javadocs in pop-up windows) appears to work fine. Is there something more specific you were concerned about that warrants a deeper investigation before merging? |
The update should be fine on anything that still compiles and does not use webRTC functionality. I don't use eclipse anymore, personally, and that was one of the more popular packages in here so i wanted a maintainer to check. |
|
I did check lutris, it uses webkitgtk for the login windows for the various game platforms. That does work. |
Methodology: - `sed` to find and replace in pkgs/* - exclude pkgs/top-level - nixpkgs-review on x86_64-linux and aarch64-linux - revert everything that doesn't build - revert everything that doesn't launch [x86_64-linux] - check upstream source whether the change makes sense [free software only]
a6132f2 to
ebf114f
Compare
|
I just fixed two oversights ( To the best of my knowledge and ability, nothing should break from this, though if it does it can easily be reverted later. |
|
@ofborg build formiko rednotebook lutris-unwrapped lutris nyxt obs-webkitgtk apache-directory-studio apvlv archi bespokesynth bitcomet claws-mail dbeaver-bin eclipse-mat ente-auth exaile giara mihomo-party minigalaxy osmo plugdata portfolio socalabs-sid ulauncher wasistlos rnnoise-plugin juce gp-saml-gui |
jerith666
left a comment
There was a problem hiding this comment.
Okay, sounds good to me. The eclipse derivation doesn't build from source, so testing basic functionality is definitely warranted there, but it seems fine -- thanks for checking!
|
Not sure how to move this forward. Pinged getchoo (familiar with the tauri things) and Alyssa (who was very helpful before). |
Methodology
sedto find and replace in pkgs/*Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.