Skip to content

nitrokey-app2: fix build#398580

Merged
FliegendeWurst merged 1 commit into
NixOS:masterfrom
wegank:nitrokey-app2-fix
Apr 14, 2025
Merged

nitrokey-app2: fix build#398580
FliegendeWurst merged 1 commit into
NixOS:masterfrom
wegank:nitrokey-app2-fix

Conversation

@wegank
Copy link
Copy Markdown
Member

@wegank wegank commented Apr 14, 2025

https://hydra.nixos.org/job/nixpkgs/trunk/nitrokey-app2.x86_64-linux

Discovered in ngi-nix/ngipkgs#800.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 14, 2025
@nix-owners nix-owners Bot requested review from 999eagle and panicgh April 14, 2025 14:51
@eljamm
Copy link
Copy Markdown
Contributor

eljamm commented Apr 14, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 398580

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14448934276


x86_64-linux

✅ 2 packages built:
  • nitrokey-app2
  • nitrokey-app2.dist

aarch64-linux

✅ 2 packages built:
  • nitrokey-app2
  • nitrokey-app2.dist

Copy link
Copy Markdown
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 14, 2025
@FliegendeWurst FliegendeWurst merged commit b4308f5 into NixOS:master Apr 14, 2025
56 of 60 checks passed
@wegank wegank deleted the nitrokey-app2-fix branch April 15, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants