Conversation
0257a76 to
8d4b677
Compare
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
|
As you know, I'm all for using the different yarn packaging tools to make things easier (as I stated in my original PR), but you raised an important point in this comment:
So how exactly is adding yarn berry 3 to nixpkgs helping your argument? Isn't it worth waiting for your own prototype to mitigate this problem and not rush to integrate yarn berry 3? |
|
The yarn-berry-fetcher which I've been working on can reliably build a cache matching the hashes in the lockfile, erroring out if anything is not reproducible exactly to the content-addressed description in the lockfile (different from using yarn, which might silently generate different result). But that still means for a yarn 3 lockfile it'll generate a yarn 3 cache in the fixed-output-derivation, and you'll need to run yarn 3 inside the normal/non-fixed-output derivation to produce a usable node_modules from the cache. |
|
Why was this merged with 0 approvals? The update script doesn't work. |
Things done
Split off from #355053
This is required to package things which have a yarn 3 lockfile.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.