Skip to content

qt6.qtdeclarative: Backport patch to fix qmlsc crash on "if + for"#398296

Merged
K900 merged 1 commit intoNixOS:stagingfrom
wineee:qt6-fix
Apr 17, 2025
Merged

qt6.qtdeclarative: Backport patch to fix qmlsc crash on "if + for"#398296
K900 merged 1 commit intoNixOS:stagingfrom
wineee:qt6-fix

Conversation

@wineee
Copy link
Member

@wineee wineee commented Apr 13, 2025 •
edited
Loading

Fix: https://bugreports.qt.io/browse/QTBUG-135288
https://bugreports.qt.io/browse/QTBUG-135885

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wineee wineee changed the title qt6.qtdeclarative: Backport patch to qmlsc crash on "if + for" qt6.qtdeclarative: Backport patch to fix qmlsc crash on "if + for" Apr 13, 2025
@wineee wineee mentioned this pull request Apr 13, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 13, 2025
@nix-owners nix-owners bot requested a review from outfoxxed April 13, 2025 08:05
@NickCao
Copy link
Member

NickCao commented Apr 16, 2025

ping @K900

@K900
Copy link
Contributor

K900 commented Apr 17, 2025

Do we even have anything that cares about qmlsc?

@wineee
Copy link
Member Author

wineee commented Apr 17, 2025

Do we even have anything that cares about qmlsc?

https://hydra.nixos.org/build/294947234

[ 93%] Built target dde-apps
make[2]: *** [panels/dock/CMakeFiles/dock-plugin.dir/build.make:134: panels/dock/.rcc/qmlcache/dock-plugin_OverflowContainer_qml.cpp] Segmentation fault (core dumped)
make[1]: *** [CMakeFiles/Makefile2:4397: panels/dock/CMakeFiles/dock-plugin.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

@K900
Copy link
Contributor

K900 commented Apr 17, 2025

Ouch.

@K900 K900 merged commit efd4a55 into NixOS:staging Apr 17, 2025
34 of 35 checks passed
@wineee wineee deleted the qt6-fix branch April 17, 2025 10:39
@FliegendeWurst FliegendeWurst mentioned this pull request Apr 20, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

@outfoxxed outfoxxed Awaiting requested review from outfoxxed

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wineee @NickCao @K900 @FliegendeWurst