dino: 0.4.5 -> 0.5.0#398018
Merged
SuperSandro2000 merged 1 commit intoNixOS:libsoup-updatesfrom Apr 21, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
SuperSandro2000
force-pushed
the
dino-0.5
branch
2 times, most recently
from
43f6314 to
d63a4df
Compare
alyssais
requested changes
Apr 12, 2025
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
|
Contributor
|
Contributor
|
so this does technically build - but i hate the overrides. It should work just as well just based on the libnice PR. |
Contributor
|
it might make sense to now stage this to be bundled with the other libsoup updates planned in |
23 tasks
SuperSandro2000
force-pushed
the
dino-0.5
branch
from
d63a4df to
c1027b3
Compare
SuperSandro2000
force-pushed
the
dino-0.5
branch
from
c1027b3 to
880eab7
Compare
Member
Author
|
I have retargeted the PR to #398783 So far I only rebuild the package but didn't start it yet as I was only on a headless system. |
alyssais
requested changes
Apr 15, 2025
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
SuperSandro2000
force-pushed
the
dino-0.5
branch
from
880eab7 to
ed85fc5
Compare
alyssais
approved these changes
Apr 15, 2025
wegank
added
the
12.approvals: 1
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
SuperSandro2000
force-pushed
the
dino-0.5
branch
from
ed85fc5 to
acac22a
Compare
Contributor
|
LordGrimmauld
approved these changes
Apr 18, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
builds and runs, nixpkgs diff looks fine to me. Thanks!
wegank
removed
the
12.approvals: 1
wegank
added
the
12.approvals: 2
47 tasks
0xda157
approved these changes
Apr 20, 2025
0xda157
added
12.approvals: 3+
SuperSandro2000
merged commit 96f6f92
into
NixOS:libsoup-updates
27 of 28 checks passed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.