Skip to content

j: rev -> tag#397676

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
guylamar2006:j-tag
Apr 17, 2025
Merged

j: rev -> tag#397676
Aleksanaa merged 1 commit intoNixOS:masterfrom
guylamar2006:j-tag

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Apr 10, 2025

Switch from rev to tag for semantic versioning.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397676

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 10, 2025
@donovanglover
Copy link
Member

Please avoid making separate PRs for things that can be fixed in treewides. Light refactoring when updating a package is acceptable, however.

@drupol
Copy link
Contributor

drupol commented Apr 11, 2025

Please avoid making separate PRs for things that can be fixed in treewides. Light refactoring when updating a package is acceptable, however.

I tried the treewide... #396749 but was reverted.

IMO, I don't have a strong opinion on this kind of PR, especially when it does not cause rebuilds.

Remove interpolation
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 15, 2025
@Aleksanaa Aleksanaa merged commit 7eb51ef into NixOS:master Apr 17, 2025
27 of 28 checks passed
@guylamar2006 guylamar2006 deleted the j-tag branch April 17, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants