Conversation
Eveeifyeve
left a comment
There was a problem hiding this comment.
Rest looks good, but big changes needed,
91abbcf to
662b81d
Compare
|
@Eveeifyeve Ok I updated it, removed the |
|
Eveeifyeve
left a comment
There was a problem hiding this comment.
Blocked merged waiting on pr scriptingosx/desktoppr#31 to be merged mainstream.
1ea92ec to
601fbe9
Compare
|
Alright. Now I updated it to fetch the SwiftPM patch from the GitHub PR, and use |
|
MattSturgeon
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
601fbe9 to
c14fae8
Compare
There was a problem hiding this comment.
LGTM, other things you might want to consider are update scripts if you want to automate the updates.
This PR adds desktoppr, a small utility to manage the desktop picture/wallpaper on macOS.
Two patches are included for the 0.5 version:
desktoppr versionas well. The 0.5 release still has the version as 0.5b, this patch corrects that.Package.swiftfile so that it can be built with Swift Package Manager, instead of the Xcode build system (the project file doesn't seem to be compatible with the deprecatedxcbuildtool in Nixpkgs). I made a PR for this patch upstream: Add support for building with Swift Package Manager scriptingosx/desktoppr#31Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.