Skip to content

desktoppr: init at 0.5#397284

Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom
andre4ik3:desktoppr
Sep 23, 2025
Merged

desktoppr: init at 0.5#397284
MattSturgeon merged 1 commit intoNixOS:masterfrom
andre4ik3:desktoppr

Conversation

@andre4ik3
Copy link
Copy Markdown
Contributor

@andre4ik3 andre4ik3 commented Apr 9, 2025

This PR adds desktoppr, a small utility to manage the desktop picture/wallpaper on macOS.

Two patches are included for the 0.5 version:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 9, 2025
@andre4ik3 andre4ik3 added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Apr 9, 2025
Comment thread pkgs/by-name/de/desktoppr/package.nix Outdated
Comment thread pkgs/by-name/de/desktoppr/package.nix Outdated
Comment thread pkgs/by-name/de/desktoppr/package.nix Outdated
Copy link
Copy Markdown
Member

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good, but big changes needed,

Comment thread pkgs/by-name/de/desktoppr/package.nix Outdated
@andre4ik3
Copy link
Copy Markdown
Contributor Author

@Eveeifyeve Ok I updated it, removed the swiftPackages for just the normal stdenv. swiftpm2nix isn't needed here because it doesn't have any dependencies outside the normal Darwin SDK.

@andre4ik3
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397284
Commit: 662b81d85b6fa53adc1856a82b4ec82a68e071bb


x86_64-darwin

✅ 1 package built:
  • desktoppr

aarch64-darwin

✅ 1 package built:
  • desktoppr

Copy link
Copy Markdown
Member

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked merged waiting on pr scriptingosx/desktoppr#31 to be merged mainstream.

Comment thread pkgs/by-name/de/desktoppr/0001-updated-version-in-code-as-well.patch Outdated
@andre4ik3 andre4ik3 force-pushed the desktoppr branch 2 times, most recently from 1ea92ec to 601fbe9 Compare September 19, 2025 17:12
@andre4ik3
Copy link
Copy Markdown
Contributor Author

Alright. Now I updated it to fetch the SwiftPM patch from the GitHub PR, and use substituteInPlace for the version fixup. I also added a version install check as a basic test the program runs and can output its version correctly.

@MattSturgeon MattSturgeon requested review from Eveeifyeve, ethancedwards8 and sikmir and removed request for ethancedwards8 September 20, 2025 12:15
@MattSturgeon
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 397284
Commit: 601fbe9bf0677d24ec574bea197356432d28ec70 (subsequent changes)
Merge: 1dc56a6166d12a220bb988ae627b958af95e4c44

Logs: https://github.com/MattSturgeon/nixpkgs-review-gha/actions/runs/17879702439


x86_64-darwin (sandbox = true)

✅ 1 package built:
  • desktoppr

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • desktoppr

Copy link
Copy Markdown
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 20, 2025
Copy link
Copy Markdown
Member

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other things you might want to consider are update scripts if you want to automate the updates.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 20, 2025
@MattSturgeon MattSturgeon added this pull request to the merge queue Sep 23, 2025
Merged via the queue into NixOS:master with commit 6a747a0 Sep 23, 2025
31 of 32 checks passed
@andre4ik3 andre4ik3 deleted the desktoppr branch September 23, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants