Skip to content

Conversation

@BirdeeHub
Copy link
Contributor

Fixes bug blocking error messages

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 8, 2025
@BirdeeHub
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396989


x86_64-linux

✅ 9 packages built:
  • lua51Packages.lze
  • lua51Packages.lzextras
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • luajitPackages.lzextras
  • vimPlugins.lze
  • vimPlugins.lzextras

@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Apr 10, 2025

@GaetanLepage if you wouldn't mind, this is a fairly decent UX upgrade I would like to push.

Also this one for lzextras if you feel like it, but it's less important.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396989


x86_64-linux

✅ 9 packages built:
  • lua51Packages.lze
  • lua51Packages.lzextras
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • luajitPackages.lzextras
  • vimPlugins.lze
  • vimPlugins.lzextras

aarch64-linux

✅ 9 packages built:
  • lua51Packages.lze
  • lua51Packages.lzextras
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • luajitPackages.lzextras
  • vimPlugins.lze
  • vimPlugins.lzextras

x86_64-darwin

✅ 9 packages built:
  • lua51Packages.lze
  • lua51Packages.lzextras
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • luajitPackages.lzextras
  • vimPlugins.lze
  • vimPlugins.lzextras

aarch64-darwin

✅ 9 packages built:
  • lua51Packages.lze
  • lua51Packages.lzextras
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • luajitPackages.lzextras
  • vimPlugins.lze
  • vimPlugins.lzextras

@GaetanLepage GaetanLepage merged commit 2aa973f into NixOS:master Apr 10, 2025
25 of 27 checks passed
@BirdeeHub BirdeeHub deleted the vimPlugins.lze branch April 10, 2025 08:56
@BirdeeHub
Copy link
Contributor Author

Ty!!

@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Apr 10, 2025

I also just opened one fixing makeBinaryWrapper --add-flags and --append-flags which you may be interested in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants