Skip to content

emacs28-macport: remove#396629

Merged
jian-lin merged 2 commits intoNixOS:masterfrom
archer-65:emacs28-mac-macport-remove
Apr 8, 2025
Merged

emacs28-macport: remove#396629
jian-lin merged 2 commits intoNixOS:masterfrom
archer-65:emacs28-mac-macport-remove

Conversation

@archer-65
Copy link
Contributor

@archer-65 archer-65 commented Apr 6, 2025 •
edited
Loading

Related to #396416.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Apr 6, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 6, 2025
@archer-65 archer-65 mentioned this pull request Apr 6, 2025
Closed
13 tasks
jian-lin
jian-lin reviewed Apr 6, 2025
View reviewed changes
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Apr 6, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 6, 2025
@archer-65 archer-65 force-pushed the emacs28-mac-macport-remove branch from 8fd2fad to 928367c Compare April 6, 2025 20:21
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 6, 2025
@archer-65 archer-65 requested a review from jian-lin April 6, 2025 20:27
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 6, 2025
jian-lin
jian-lin reviewed Apr 6, 2025
View reviewed changes
Copy link
Contributor

@jian-lin jian-lin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

After unrelated lines are removed from release notes and the "fixup" commit (emacs28-macport: clarify alias throw message) is removed, I think it will be mergable.

@archer-65 archer-65 force-pushed the emacs28-mac-macport-remove branch from 928367c to edd9c0b Compare April 6, 2025 21:09
@archer-65 archer-65 force-pushed the emacs28-mac-macport-remove branch from edd9c0b to fd6b4e2 Compare April 6, 2025 21:13
@archer-65 archer-65 requested a review from jian-lin April 6, 2025 21:14
@archer-65 archer-65 force-pushed the emacs28-mac-macport-remove branch from fd6b4e2 to 2f53908 Compare April 6, 2025 21:17
@archer-65
Copy link
Contributor Author

archer-65 commented Apr 6, 2025 •
edited
Loading

@jian-lin Out of curiosity, have the changes in #386596 been reverted for any reason?

@jian-lin
Copy link
Contributor

jian-lin commented Apr 6, 2025

They got moved to another release note files:

nixpkgs/doc/release-notes/rl-2505.section.md

Line 275 in 074936e

- Emacs 28 and 29 have been removed.
.

That new release note file is introduced recently. (Maybe this Emacs macport release notes should also moved there.)

@archer-65 archer-65 force-pushed the emacs28-mac-macport-remove branch from 2f53908 to 2472eda Compare April 6, 2025 21:25
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes labels Apr 6, 2025
@archer-65
Copy link
Contributor Author

archer-65 commented Apr 6, 2025

They got moved to another release note files:

nixpkgs/doc/release-notes/rl-2505.section.md

Line 275 in 074936e

- Emacs 28 and 29 have been removed.

.

That new release note file is introduced recently. (Maybe this Emacs macport release notes should also moved there.)

Done!

@github-actions github-actions bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Apr 6, 2025
@jian-lin jian-lin merged commit ceb6810 into NixOS:master Apr 8, 2025
25 of 27 checks passed
@archer-65 archer-65 deleted the emacs28-mac-macport-remove branch April 8, 2025 21:11
panchoh
panchoh reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@panchoh panchoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late for the party, but nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jian-lin jian-lin jian-lin approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@ttuegel ttuegel Awaiting requested review from ttuegel

@adisbladis adisbladis Awaiting requested review from adisbladis

+1 more reviewer

@panchoh panchoh panchoh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: emacs Text editor 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archer-65 @jian-lin @panchoh