Skip to content

treewide: add back missing libGL and libX11 for packages depending on SDL2#396612

Merged
K900 merged 17 commits intoNixOS:staging-nextfrom
LordGrimmauld:sdl-dep-fixes-2
Apr 6, 2025
Merged

treewide: add back missing libGL and libX11 for packages depending on SDL2#396612
K900 merged 17 commits intoNixOS:staging-nextfrom
LordGrimmauld:sdl-dep-fixes-2

Conversation

@LordGrimmauld
Copy link
Contributor

Continuation of #395499

These were broken by #393386

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: games Gaming on NixOS label Apr 6, 2025
@LordGrimmauld LordGrimmauld requested a review from K900 April 6, 2025 18:03
@LordGrimmauld LordGrimmauld marked this pull request as draft April 6, 2025 18:03
@LordGrimmauld LordGrimmauld marked this pull request as ready for review April 6, 2025 18:05
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 6, 2025
@LordGrimmauld LordGrimmauld marked this pull request as draft April 6, 2025 18:16
@LordGrimmauld
Copy link
Contributor Author

Seems some are still missing deps on some platforms because propagation is weird - will update those.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396612


aarch64-linux

⏩ 3 packages marked as broken and skipped:
  • syncterm
  • warsow
  • warsow-engine
❌ 4 packages failed to build:
  • inochi-creator
  • inochi-session
  • q2pro
  • vpv
✅ 11 packages built:
  • bugdom
  • cataclysm-dda
  • cataclysm-dda-git
  • cro-mag-rally
  • endless-sky
  • jazz2
  • nanosaur2
  • neverball
  • vdrift-bin
  • vivictpp
  • vkquake

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396612


aarch64-linux

⏩ 3 packages marked as broken and skipped:
  • syncterm
  • warsow
  • warsow-engine
✅ 15 packages built:
  • bugdom
  • cataclysm-dda
  • cataclysm-dda-git
  • cro-mag-rally
  • endless-sky
  • inochi-creator
  • inochi-session
  • jazz2
  • nanosaur2
  • neverball
  • q2pro
  • vdrift-bin
  • vivictpp
  • vkquake
  • vpv

@LordGrimmauld LordGrimmauld marked this pull request as ready for review April 6, 2025 19:53
@K900 K900 merged commit c7c96c5 into NixOS:staging-next Apr 6, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants