Skip to content

pocket-casts: 0.9.0 -> 0.10.2#396575

Merged
yayayayaka merged 2 commits intoNixOS:masterfrom
tanya1866:pocket-casts
Apr 14, 2025
Merged

pocket-casts: 0.9.0 -> 0.10.2#396575
yayayayaka merged 2 commits intoNixOS:masterfrom
tanya1866:pocket-casts

Conversation

@tanya1866
Copy link
Contributor

@tanya1866 tanya1866 commented Apr 6, 2025

Things done

Update pocket-casts: 0.9.0 -> 0.10.2
Closes #396548
Maintainer: @yayayayaka

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 6, 2025
@nix-owners nix-owners bot requested a review from yayayayaka April 6, 2025 15:09
@wlcx
Copy link
Contributor

wlcx commented Apr 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396575


x86_64-linux

❌ 1 package failed to build:
  • pocket-casts

@tanya1866 tanya1866 marked this pull request as draft April 6, 2025 16:13
@tanya1866 tanya1866 marked this pull request as ready for review April 7, 2025 08:56
@tanya1866
Copy link
Contributor Author

@wlcx sorry, i built it locally and its working now

@wlcx
Copy link
Contributor

wlcx commented Apr 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396575


x86_64-linux

✅ 1 package built:
  • pocket-casts

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 9, 2025
@tanya1866 tanya1866 requested a review from wlcx April 13, 2025 10:05
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the update on x86_64-linux and the diff is looking fine by me, thanks! ❤️

@yayayayaka
Copy link
Member

Additionally bumped the Electron version according to the package.json and tested it with the new version.

@yayayayaka yayayayaka merged commit 3688e2b into NixOS:master Apr 14, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: pocket-casts 0.9.0 → 0.10.2

5 participants