Skip to content

systemd: disable pacret hardening flag if withLibBPF#396368

Merged
arianvp merged 1 commit intoNixOS:stagingfrom
risicle:ris-systemd-disable-pacret
Apr 15, 2025
Merged

systemd: disable pacret hardening flag if withLibBPF#396368
arianvp merged 1 commit intoNixOS:stagingfrom
risicle:ris-systemd-disable-pacret

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Apr 5, 2025

..for the same reason as other flags mentioned here.

Really we should not be using a wrapped clang for bpf compilation. See the #323869 saga for more information.

Without this change, systemd fails to build on aarch64-linux in the pkgsExtraHardening packageset.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

for same reason as other flags mentioned here - really we should
not be using a wrapped clang for bpf compilation
@github-actions github-actions bot added the 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. label Apr 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 5, 2025
@nix-owners nix-owners bot requested a review from kloenk April 5, 2025 15:45
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5388

Copy link
Member

@arianvp arianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there a tracking issue for the wrapped clang stuff?

@arianvp arianvp merged commit d7e5a04 into NixOS:staging Apr 15, 2025
26 of 27 checks passed
@risicle
Copy link
Contributor Author

risicle commented Apr 15, 2025

I don't think so, a lot of discussion spun out @ #318674 & #323869, but most people appear to have put more effort into suppressing the warnings I added than addressing the actual problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants