systemd: disable pacret hardening flag if withLibBPF#396368
Merged
arianvp merged 1 commit intoNixOS:stagingfrom Apr 15, 2025
Merged
systemd: disable pacret hardening flag if withLibBPF#396368arianvp merged 1 commit intoNixOS:stagingfrom
pacret hardening flag if withLibBPF#396368arianvp merged 1 commit intoNixOS:stagingfrom
Conversation
for same reason as other flags mentioned here - really we should not be using a wrapped clang for bpf compilation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5388 |
arianvp
approved these changes
Apr 15, 2025
Member
arianvp
left a comment
There was a problem hiding this comment.
Thanks! Is there a tracking issue for the wrapped clang stuff?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..for the same reason as other flags mentioned here.
Really we should not be using a wrapped clang for bpf compilation. See the #323869 saga for more information.
Without this change,
systemdfails to build on aarch64-linux in thepkgsExtraHardeningpackageset.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.