lx-music-desktop: build from source, bump electron version#395977
Merged
flokli merged 1 commit intoNixOS:masterfrom Apr 25, 2025
Merged
lx-music-desktop: build from source, bump electron version#395977flokli merged 1 commit intoNixOS:masterfrom
flokli merged 1 commit intoNixOS:masterfrom
Conversation
TomaSajt
force-pushed
the
lx-music-desktop
branch
from
c8f384c to
579e81a
Compare
github-actions
bot
added
10.rebuild-darwin: 1
TomaSajt
force-pushed
the
lx-music-desktop
branch
5 times, most recently
from
6d59f20 to
9d33e3d
Compare
StarryReverie
approved these changes
Apr 11, 2025
Contributor
|
Thank you for your great work! |
wegank
added
12.approved-by: package-maintainer
TomaSajt
force-pushed
the
lx-music-desktop
branch
from
9d33e3d to
bffe72c
Compare
TomaSajt
changed the title
StarryReverie
approved these changes
Apr 23, 2025
TomaSajt
force-pushed
the
lx-music-desktop
branch
from
bffe72c to
d0a3987
Compare
TomaSajt
force-pushed
the
lx-music-desktop
branch
from
d0a3987 to
cc2161c
Compare
22 tasks
Member
|
yayayayaka
approved these changes
Apr 25, 2025
Member
yayayayaka
left a comment
yayayayaka
left a comment
There was a problem hiding this comment.
Built and tested the application on x86_64-linux and the diff is looking fine to me.
If nobody objects, I would merge this soon.
wegank
added
12.approvals: 2
Member
|
LGTM as well, let's get this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #295770
Because we build from source we can use
electron.headersof any electron version, not just electron_32.Don't want to debug darwin...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.