python312Packages.pysdl2: 0.9.17 -> 0.9.17-unstable-2025-04-03, fix for sdl2-compat#395688
Merged
K900 merged 1 commit intoNixOS:masterfrom Apr 18, 2025
Merged
python312Packages.pysdl2: 0.9.17 -> 0.9.17-unstable-2025-04-03, fix for sdl2-compat#395688K900 merged 1 commit intoNixOS:masterfrom
K900 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
Related: this breaks with #393386 which is currently in staging. That motivated this fix. |
LordGrimmauld
force-pushed
the
pysdl-compat
branch
from
2289429 to
afef84f
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
|
13 tasks
Henry-Hiles
approved these changes
Apr 18, 2025
Henry-Hiles
added
the
12.approvals: 1
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pysdl2 is mostly unmaintained. However, i wanted to fix it instead of dropping it outright - we can still drop it later. Upstream fixed a couple tests with sdl2-compat, but not all tests work on sdl2-compat in our build sandbox. This is partially due to sdl2-compat not explicitly expecting an x11 display, which means it returns errors on some method calls.
This PR skips the tests that are broken with sdl2-compat, and fixes the shared object file being loaded to work properly with sdl2-compat.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.