koodo-reader: 1.7.4 -> 2.0.9

[TomaSajt]

The app now has node-gyp based native deps so I needed to add python, electron-headers, and some other hacks.

https://github.com/koodo-reader/koodo-reader/releases

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[TomaSajt]

Missing the xcbuild from nativeBuildInputs...

IIRC this is because yarnConfigHook doesn't set up the same node-gyp override as npmConfigHook (npmConfigHook patches the xcbuild dependency out).

I should probably look into whether or not we should also have this logic in the yarnConfigHook.

[TomaSajt]

Does env.CSC_IDENTITY_AUTO_DISCOVERY = "false"; not actually work?

[ghost]

2.0.9 is out

[TomaSajt]

Updated to 2.0.9

Could you test it out?

[ghost]

Could you test it out?

good in linux x64

[ghost]

koodo-reader> $ /nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/.bin/electron-builder --dir -c.electronDist=electron-dist -c.electronVersion=35.7.4
koodo-reader>   • injecting environment  envFile=/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/electron-builder.env
koodo-reader>   • electron-builder  version=26.0.12 os=23.6.0
koodo-reader>   • loaded configuration  file=package.json ("build" field)
koodo-reader>   • @electron/rebuild already used by electron-builder, please consider to remove excess dependency from devDependencies
koodo-reader> 
koodo-reader> To ensure your native dependencies are always matched electron version, simply add script `"postinstall": "electron-builder install-app-deps" to your `package.json`
koodo-reader>   • writing effective config  file=dist/builder-effective-config.yaml
koodo-reader>   • executing @electron/rebuild  electronVersion=35.7.4 arch=arm64 buildFromSource=false appDir=./
koodo-reader>   • installing native dependencies  arch=arm64
koodo-reader>   • preparing       moduleName=better-sqlite3 arch=arm64
koodo-reader>   • finished        moduleName=better-sqlite3 arch=arm64
koodo-reader>   • preparing       moduleName=cpu-features arch=arm64
koodo-reader>   • finished        moduleName=cpu-features arch=arm64
koodo-reader>   • completed installing native dependencies
koodo-reader>   • packaging       platform=darwin arch=arm64 electron=35.7.4 appOutDir=dist/mac-arm64
koodo-reader>   • custom electronDist provided but no zip found; assuming unpacked electron directory.  electronDist=electron-dist expectedFile=electron-v35.7.4-darwin-arm64.zip
koodo-reader>   • copying Electron  source=/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/electron-dist/Electron.app destination=/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/dist/mac-arm64/Electron.app
koodo-reader>   ⨯ spawn EPERM     failedTask=build stackTrace=Error: spawn EPERM
koodo-reader>     at ChildProcess.spawn (node:internal/child_process:420:11)
koodo-reader>     at spawn (node:child_process:754:9)
koodo-reader>     at execFile (node:child_process:347:17)
koodo-reader>     at /nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/builder-util/src/util.ts:99:13
koodo-reader>     at new Promise (<anonymous>)
koodo-reader>     at exec (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/builder-util/src/util.ts:98:10)
koodo-reader>     at getValidIdentities (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:234:11)
koodo-reader>     at _findIdentity (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:269:23)
koodo-reader>     at findIdentity (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:332:12)
koodo-reader>     at MacPackager.sign (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/macPackager.ts:257:36)
koodo-reader> error Command failed with exit code 1.
koodo-reader> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error: Cannot build '/nix/store/q7334322cc24ni94xi6h7zcy94gakfin-koodo-reader-2.0.9.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/l3j8d6bgg27dk66fa91h043nv9azynjp-koodo-reader-2.0.9
       Last 25 log lines:
       > To ensure your native dependencies are always matched electron version, simply add script `"postinstall": "electron-builder install-app-deps" to your `package.json`
       >   • writing effective config  file=dist/builder-effective-config.yaml
       >   • executing @electron/rebuild  electronVersion=35.7.4 arch=arm64 buildFromSource=false appDir=./
       >   • installing native dependencies  arch=arm64
       >   • preparing       moduleName=better-sqlite3 arch=arm64
       >   • finished        moduleName=better-sqlite3 arch=arm64
       >   • preparing       moduleName=cpu-features arch=arm64
       >   • finished        moduleName=cpu-features arch=arm64
       >   • completed installing native dependencies
       >   • packaging       platform=darwin arch=arm64 electron=35.7.4 appOutDir=dist/mac-arm64
       >   • custom electronDist provided but no zip found; assuming unpacked electron directory.  electronDist=electron-dist expectedFile=electron-v35.7.4-darwin-arm64.zip
       >   • copying Electron  source=/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/electron-dist/Electron.app destination=/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/dist/mac-arm64/Electron.app
       >   ⨯ spawn EPERM     failedTask=build stackTrace=Error: spawn EPERM
       >     at ChildProcess.spawn (node:internal/child_process:420:11)
       >     at spawn (node:child_process:754:9)
       >     at execFile (node:child_process:347:17)
       >     at /nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/builder-util/src/util.ts:99:13
       >     at new Promise (<anonymous>)
       >     at exec (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/builder-util/src/util.ts:98:10)
       >     at getValidIdentities (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:234:11)
       >     at _findIdentity (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:269:23)
       >     at findIdentity (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/codeSign/macCodeSign.ts:332:12)
       >     at MacPackager.sign (/nix/var/nix/builds/nix-build-koodo-reader-2.0.9.drv-4903-1999501759/source/node_modules/app-builder-lib/src/macPackager.ts:257:36)
       > error Command failed with exit code 1.
       > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
       For full logs, run:
         nix log /nix/store/q7334322cc24ni94xi6h7zcy94gakfin-koodo-reader-2.0.9.drv

[TomaSajt]

Looks like yorenapu just deleted their account, that was quick...

@sotubani I'll create a followup PR where I try do disable the signing logic