Skip to content

crystal_1_14: drop#395500

Draft
donovanglover wants to merge 1 commit intoNixOS:masterfrom
donovanglover:crystal-1.14
Draft

crystal_1_14: drop#395500
donovanglover wants to merge 1 commit intoNixOS:masterfrom
donovanglover:crystal-1.14

Conversation

@donovanglover
Copy link
Member

https://crystal-lang.org/releases

We no longer need to keep around the latest version released with a stable NixOS since Crystal has been at 1.x for a while now.

Most software in nixpkgs should be able to be built with the latest version of Crystal. Software depending on internal APIs should have their build failures reported upstream since other distributions won't ship older versions of Crystal.

cc @peterhoeg for adding the original comment

Part of #380143

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

We no longer need to keep around the latest version released with a
stable NixOS since Crystal has been at 1.x for a while now.

Most software in nixpkgs should be able to be built with the latest
version of Crystal. Software depending on internal APIs should have
their build failures reported upstream since other distributions won't
ship older versions of Crystal.
@github-actions github-actions bot added the 6.topic: crystal Programming language - https://crystal-lang.org/ label Apr 2, 2025
@donovanglover donovanglover requested a review from a team April 2, 2025 14:26
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 2, 2025
@will
Copy link
Contributor

will commented Apr 3, 2025

One problem with dropping 1.14 is that 1.15 (and 1.15.1) broke support for the (afaik only) ssh library spider-gazelle/ssh2.cr#22 crystal-lang/crystal#15377

It has been convenient for me to have 1.14 around to fall back to, but also I suppose it wouldn't be the end of the world to pin an extra old version of nixpkgs to still keep 1.14 around. So I'm not against dropping it, just wanted to share this problem.

@donovanglover
Copy link
Member Author

I think that's a good reason to keep 1.14 for now. Not sure when wait_readable will be merged but it's also a blocker for phil294/AHK_X11#89 (comment) (which builds with 1.14 but not 1.15)

@donovanglover donovanglover marked this pull request as draft April 3, 2025 13:19
@donovanglover donovanglover added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Apr 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 7, 2025
@UlyssesZh
Copy link
Member

Crystal 1.16 now has Crystal::EventLoop.current.wait_readable, and AHK_X11 is working with Crystal 1.16 and is no longer a block for dropping Crystal 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 6.topic: crystal Programming language - https://crystal-lang.org/ 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants