sdl2-compat: 2.32.52 -> 2.32.54#395227
Merged
leona-ya merged 1 commit intoNixOS:stagingfrom Apr 24, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 11-100
Contributor
There was a problem hiding this comment.
The changelog states that sdl2_compat.pc has been renamed to sdl2-compat.pc, the package will need to be adjusted for this.
Edit: Also this requires #395231 since they raised the SDL3 version requirement.
Member
Merged! |
Contributor
Author
|
I'll rebase after 7-8 hours. |
Contributor
what happened to this plan? And please adjust the symlink pointing to |
Contributor
Author
I just forgot, wait a minute. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
I applied it. |
LordGrimmauld
approved these changes
Apr 6, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
The change itself is correct - however, since #393386 sdl2-compat became a mass rebuild. Merging it to master might be problematic. This might have to target staging/staging-next, i'll have to check procedures here.
Contributor
|
After asking people in the staging channel on matrix, i was told this should probably go to |
Contributor
|
github-actions
bot
added
10.rebuild-darwin: 1001-2500
LordGrimmauld
approved these changes
Apr 6, 2025
marcin-serwin
approved these changes
Apr 6, 2025
wegank
added
12.approved-by: package-maintainer
LordGrimmauld
added
the
8.has: package (update)
Contributor
|
|
LordGrimmauld
requested changes
Apr 23, 2025
Contributor
There was a problem hiding this comment.
@MisileLab passthru tests will fail unless you fix the meta, as pointed out by nadia:
diff --git a/pkgs/by-name/sd/sdl2-compat/package.nix b/pkgs/by-name/sd/sdl2-compat/package.nix
index fb6d419e7969..23da12cc8057 100644
--- a/pkgs/by-name/sd/sdl2-compat/package.nix
+++ b/pkgs/by-name/sd/sdl2-compat/package.nix
@@ -108,6 +108,6 @@ stdenv.mkDerivation (finalAttrs: {
marcin-serwin
];
platforms = lib.platforms.all;
- pkgConfigModules = [ "sdl2_compat" ];
+ pkgConfigModules = [ "sdl2-compat" ];
};
})Would love to get this merged soon, but the fix would be nice before that.
https://github.com/libsdl-org/sdl2-compat/releases/tag/release-2.32.54 Signed-off-by: misilelab <misileminecord@gmail.com>
nadiaholmquist
approved these changes
Apr 24, 2025
LordGrimmauld
approved these changes
Apr 24, 2025
leona-ya
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/libsdl-org/sdl2-compat/releases/tag/release-2.32.54
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.