lib/modules: Reject extra attributes on properties#394852
Draft
roberth wants to merge 3 commits intoNixOS:masterfrom
Draft
lib/modules: Reject extra attributes on properties#394852roberth wants to merge 3 commits intoNixOS:masterfrom
roberth wants to merge 3 commits intoNixOS:masterfrom
Conversation
... because they would be ignored, and their presence is probably a user mistake. This reduces our forward compatibility, but I doubt that we need any here, and I doubt that the forward compatibility behavior should be anything other than an error anyway.
github-actions
bot
added
6.topic: nixos
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1
hsjobeki
reviewed
Apr 1, 2025
Contributor
hsjobeki
left a comment
hsjobeki
left a comment
There was a problem hiding this comment.
Looking lgtm to me.
Would be nicer to throw a better error message if an unsuppported propery is passed.
Attribute not found isn't quite describing the error if a person run into this error.
Contributor
This should be able to publicly confirm soon: |
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... because they would be ignored, and their presence is probably a (easy) user mistake.
This reduces our forward compatibility, but I doubt that we need any here, and I doubt that the forward compatibility behavior should be anything other than an error anyway.
TODO
mkOverrideContext:
I'm using a lambda call to perform this check with minimal function calls. This should reduce allocations and time spent (unconfirmed) at a small penalty in terms of error message quality. I believe this would be the right trade-off.
mkIf's from being//'d, and co. #72949Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.