Merged
Conversation
Member
|
@GrahamcOfBorg build singular |
|
Success on x86_64-linux (full log) Attempted: singular Partial log (click to expand)
|
Member
|
I just noticed the following line in the build log:
Don't think that's a problem however. |
|
Success on aarch64-linux (full log) Attempted: singular Partial log (click to expand)
|
Member
Author
|
Better safe than sorry, I fixed the warning. |
Member
|
@GrahamcOfBorg build singular |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: singular Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: singular Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: singular Partial log (click to expand)
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I added the ntl dependency in my recent PR (#38768). I failed to actually tell singular where to find it though, so its not used.
I'm pretty sure this worked for me before and I can't remember removing the
--with-ntlline, but it doesn't find it now so I must've removed it some time.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)