emacs-macport: 29.4 -> 30.1 #393512
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| diff --git a/src/conf_post.h b/src/conf_post.h | ||
| index e3272278832..01d3bcf9a81 100644 | ||
| --- a/src/conf_post.h | ||
| +++ b/src/conf_post.h | ||
| @@ -58,6 +58,7 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. */ | ||
| #if NS_IMPL_GNUSTEP || defined __MINGW32__ | ||
| typedef unsigned int bool_bf; | ||
| #else | ||
| +#include <stdbool.h> /* Clang in C mode does not automatically define bool unless you explicitly include that header */ | ||
| typedef bool bool_bf; | ||
| #endif | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| #if __has_include("config.h") | ||
| #include "config.h" | ||
| #endif | ||
|
|
||
| #ifndef NOESCAPE_NOOP_H_ | ||
| #define NOESCAPE_NOOP_H_ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| lib, | ||
| fetchFromBitbucket, | ||
| fetchFromGitHub, | ||
| fetchFromSavannah, | ||
| }: | ||
|
|
||
|
|
@@ -31,8 +32,8 @@ let | |
| } | ||
| ); | ||
| "macport" = ( | ||
|
||
| fetchFromGitHub { | ||
| owner = "jdtsmith"; | ||
| repo = "emacs-mac"; | ||
| inherit rev hash; | ||
| } | ||
|
|
@@ -88,7 +89,9 @@ let | |
| matthewbauer | ||
| panchoh | ||
| ]; | ||
| "macport" = with lib.maintainers; [ | ||
| lactose | ||
| ]; | ||
| } | ||
| .${variant}; | ||
| platforms = | ||
|
|
@@ -121,40 +124,12 @@ in | |
| ]; | ||
| }); | ||
|
|
||
| emacs30-macport = import ./make-emacs.nix (mkArgs { | ||
| pname = "emacs-mac"; | ||
| version = "30.1.50"; | ||
|
Contributor
There was a problem hiding this comment. @juuyokka I think latest version is now at "30.2.50". See jdtsmith/emacs-mac@34f3540 |
||
| variant = "macport"; | ||
| rev = "a50f20585960d92510fb62c95cb12606218a2081"; | ||
| hash = "sha256-Ap4ZBb9NYIbwLroOoqvpQU/hjhaJJDB+3/1V0Q2c6aA="; | ||
| patches = _: [ ./macport-stdbool.patch ]; | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juuyokka is
apple-sdk_14the minimum sdk version that is needed for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has additional functionality on newer SDKs. There is no harm in using a newer SDK for a correctly-written application that does runtime availability checks before using newer APIs, and this appears to do so. However, macOS 14 will be the baseline for 25.11 anyway, so it may not be worth explicitly specifying until they implement optional functionality for newer versions.