Skip to content

emacs: add panchoh as maintainer#393504

Merged
jian-lin merged 3 commits intoNixOS:masterfrom
panchoh:maintainers
Mar 27, 2025
Merged

emacs: add panchoh as maintainer#393504
jian-lin merged 3 commits intoNixOS:masterfrom
panchoh:maintainers

Conversation

@panchoh
Copy link
Copy Markdown
Contributor

@panchoh panchoh commented Mar 26, 2025

I humbly request to join the Emacs brotherhood here, and help maintain the Emacs module in nixpkgs.

I’m aware that I still have much to learn, but I’ve also managed to get a couple of bumps right.

By becoming a maintainer here, I reckon that I’ll get notified whenever PRs are opened that affect the Emacs module, and that will help me become more proficient in it (instead of having to hunt for those PRs when I remember to).

I also plan to become a maintainer of the Emacs module on stylix.

As background, my first contribution to nixpkgs was a simple fix for caddy, back in 2020, and since then I've fallen in love hard with nix, and NixOS has been my daily driver for my humble fleet of boxen for two years now (I’m actually somewhat proud if my flake).

I also help maintain autofirma-nix, which was recently accepted into the nix-community org, yay!

I used to maintain a build of Emacs 28 on Arch Linux’ AUR, back when native compilation was all the rage.

I’d appreciate any feedback you have to give me, especially if this approach is not appropriate.

Thanks for your time and attention, and may the winter snows be gentle upon your roof.

CC @jian-lin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: emacs Text editor 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 26, 2025
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome.

In addition to the Emacs package (pkgs.emacs), would you like to maintain other Emacs-related things such as Emacs lisp packages (pkgs.emacs.pkgs.foo)? If so, please also add your maintainer entry here.

@adisbladis
Copy link
Copy Markdown
Member

Welcome indeed!

Having lots to learn is absolutely not a blocker to join the group of maintainers (who doesn't have lots to learn?). That's why we have multiple maintainers.

Just awaiting a response on whether you also want to be involved in the package set :)

@AndersonTorres
Copy link
Copy Markdown
Member

Welcome aboard!
And do not worry with the grey tests.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. labels Mar 27, 2025
@github-actions github-actions bot added the 6.topic: teams Relating to team creation, updates, other management actions label Mar 27, 2025
@panchoh
Copy link
Copy Markdown
Contributor Author

panchoh commented Mar 27, 2025

Thanks for the warm welcome, folks.

And I appreciate your words of encouragement.

Yes, I’ll gladly add myself to the Emacs team, and help with the rest of the ecosystem, thanks for bringing that up!

Now that we are at it, I’ll ask: how do you coordinate as a team? Any room on Matrix, or by any other means?

Ah, I’m also a big fan of pair programming, so if you ever fancy a session, just ping me and we’ll make it happen.

Again, thanks for this. <3

@jian-lin
Copy link
Copy Markdown
Contributor

There is a matrix room #emacs:nixos.org. Maybe we should add it somewhere in the manual.

@jian-lin jian-lin merged commit ac1fbdd into NixOS:master Mar 27, 2025
26 of 29 checks passed
@panchoh panchoh deleted the maintainers branch March 27, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 6.topic: teams Relating to team creation, updates, other management actions 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants