Merged
Conversation
teto
reviewed
Mar 26, 2025
Member
|
cool ! could you install the zsh completion as well please ? https://github.com/neovim/neovim/blob/master/contrib/zsh-completion.zsh |
github-actions
bot
added
10.rebuild-darwin: 101-500
doronbehar
reviewed
Mar 26, 2025
Contributor
|
Ran
Is this file superior to this ZSH distributed file? I think not. I wonder why upstream decided to maintain that by themselves. |
Contributor
Author
|
Contributor
|
Everything looks good for me, like the new |
Member
|
Please don't merge yet, I also would want to review it |
PerchunPak
approved these changes
Mar 26, 2025
wegank
added
12.approved-by: package-maintainer
Contributor
Author
|
I will merge the update as is. |
Member
|
I think we lost internationalisation as was mentioned on release notes https://neovim.io/news/2025/03 try export LANG=fr_FR.utf8 for instance on a commit before the update and you have the UI in French. After this commit not anymore. This fixes it
As the ecosystem is overwhelmingly designed, software is responsible to provide its autocompletion. I think it makes sense not to have to wait for a zsh update (which I believe releases less than neovim) to obtain the new flags autocompleted. I added the zsh autocompletion as a matter of fact. I didn't copy the zsh's one because it seemed a tad messy and I was maybe secretly hoping to nerdsnipe someone into improving it. It's probably fine not to bundle it here but I hope that some zsh expert can improve it :) |
Contributor
Author
Thanks for the heads up @teto ! Can you make a PR? |
13 tasks
Member
|
PR created at #394024. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
:checkhealthreport no errorsDiff: neovim/neovim@v0.10.4...v0.11.0
Changelog: https://github.com/neovim/neovim/releases/tag/v0.11.0
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.