sdl2-compat: symlink package config specification file into sdl2.pc#393342
Merged
K900 merged 1 commit intoNixOS:masterfrom Mar 26, 2025
Merged
sdl2-compat: symlink package config specification file into sdl2.pc#393342K900 merged 1 commit intoNixOS:masterfrom
K900 merged 1 commit intoNixOS:masterfrom
Conversation
LordGrimmauld
requested review from
K900,
marcin-serwin,
nadiaholmquist and
peterhoeg
LordGrimmauld
force-pushed
the
sdl2_compat_prep
branch
2 times, most recently
from
0caecb1 to
98b63c0
Compare
Previously, replacing SDL2 with sdl2-compat with dependents on the SDL2 pkgconfig file would just break.
An example for this breakage is pkgs.ffmpeg.override { SDL2 = pkgs.sdl2-compat; }.
This is fixed by symlinking the missing sdl2.pc file to point to sdl2_compat.pc.
This is analogous to NixOS#388304 (aa8bb53)
LordGrimmauld
force-pushed
the
sdl2_compat_prep
branch
from
98b63c0 to
68fc06f
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, replacing SDL2 with sdl2-compat with dependents on the SDL2 pkgconfig file would just break. An example for this breakage is pkgs.ffmpeg.override { SDL2 = pkgs.sdl2-compat; }. This is fixed by symlinking the missing sdl2.pc file to point to sdl2_compat.pc.
This is analogous to #388304 (aa8bb53)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.