Skip to content

jigasi: 1.1-311-g3de47d0 -> 1.1-374-g0ab957c, fix build#393176

Closed
ghpzin wants to merge 1 commit intoNixOS:masterfrom
ghpzin:jigasi/1.1-311-g3de47d0/1.1-374-g0ab957c
Closed

jigasi: 1.1-311-g3de47d0 -> 1.1-374-g0ab957c, fix build#393176
ghpzin wants to merge 1 commit intoNixOS:masterfrom
ghpzin:jigasi/1.1-311-g3de47d0/1.1-374-g0ab957c

Conversation

@ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Mar 25, 2025

jigasi: 1.1-311-g3de47d0 -> 1.1-374-g0ab957c, fix build


Fixes build failure of jigasi since 2025-02-07 (addition of noBrokenSymlinks hook #370750):
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.jigasi.x86_64-linux
https://hydra.nixos.org/build/293018164

Error log:

ERROR: noBrokenSymlinks: the symlink /nix/store/xshm74p1i8939bh23bjmh9kk8q3lqq5g-jigasi-1.1-311-g3de47d0/share/jigasi/lib/libunix-java.so points to a missing target: /nix/store/xshm74p1i8939bh23bjmh9kk8q3lqq5g-jigasi-1.1-311-g3de47d0/share/jigasi/lib/libunix-0.5.1.so
ERROR: noBrokenSymlinks: found 1 dangling symlinks, 0 reflexive symlinks and 0 unreadable symlinks

.deb file from previous version (1.1-311-g3de47d0) had broken symlink inside:

dpkg-deb --contents /nix/store/aj8rfp6y5rykh2b7qaz0w1nks5h6yg17-jigasi_1.1-311-g3de47d0-1_all.deb | grep 'libunix'
lrwxrwxrwx root/root         0 2023-09-28 02:41 ./usr/share/jigasi/lib/libunix-java.so -> libunix-0.5.1.so

No symlinks in .deb of new version (1.1-374-g0ab957c):

dpkg-deb --contents /nix/store/c9azk4fxnbfrs2zhkqw4m0id2z7wncv2-jigasi_1.1-374-g0ab957c-1_all.deb | grep '\->'
# nothing

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2025
@ghpzin
Copy link
Contributor Author

ghpzin commented Mar 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393176


x86_64-linux

✅ 1 package built:
  • jigasi

Also manually run nix-build -A jigasi.passthru.tests.single-node-smoke-test and it passed (not sure if anything else will run it, as it depends on jitsi-meets that it is marked as insecure)

@ghpzin ghpzin closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant