Skip to content

gst_all_1.gst-plugins-good: fix build for musl#393037

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:gst-plugins-good-musl
Mar 28, 2025
Merged

gst_all_1.gst-plugins-good: fix build for musl#393037
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:gst-plugins-good-musl

Conversation

@alyssais
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label Mar 25, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 6.topic: musl Running or building packages with musl libc labels Mar 25, 2025
@nix-owners nix-owners bot requested a review from matthewbauer March 25, 2025 10:14
@alyssais alyssais requested a review from jtojnar March 25, 2025 10:15
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Hopefully, this will still apply with #390268

(fetchpatch {
name = "musl.patch";
url = "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/dd1fc2b7931f5789815e17dda2ef7c31b9fba563.patch";
stripLen = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this is enough without extraPrefix = ""; to add a/ and b/ prefixes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because it leaves the "gst-plugins-good/" prefix, which functions the same as a/ and b/ would.

@alyssais
Copy link
Member Author

Thanks. Hopefully, this will still apply with #390268

Pretty sure it will. I just missed out on getting it into 1.26.0. (My other musl fix submitted just before did make it — that was a fix for a regression introduced after 1.24 so we don't need to worry about it.)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 25, 2025
@alyssais alyssais merged commit 3390088 into NixOS:staging Mar 28, 2025
29 checks passed
@alyssais alyssais deleted the gst-plugins-good-musl branch March 28, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants