Skip to content

nixos/xrdp: use --replace-fail with substituteInPlace#392206

Merged
drupol merged 1 commit intoNixOS:masterfrom
SuperSandro2000:xrdp-fail
Mar 23, 2025
Merged

nixos/xrdp: use --replace-fail with substituteInPlace#392206
drupol merged 1 commit intoNixOS:masterfrom
SuperSandro2000:xrdp-fail

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 22, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@drupol drupol merged commit 7324582 into NixOS:master Mar 23, 2025
42 of 43 checks passed
@spiage
Copy link

spiage commented Mar 23, 2025

@SuperSandro2000 Hi!
I have this issue now

note: keeping build directory '/tmp/nix-build-xrdp.conf.drv-0/build'
error: builder for '/nix/store/bklkiz5d53y95qby0r5pqd7srh2dd5zh-xrdp.conf.drv' failed with exit code 1;
       last 1 log lines:
       > substituteStream() in derivation xrdp.conf: ERROR: pattern EnableSyslog=1 doesn't match anything in file '/nix/store/ly8sl0fwhg2pc87f12k1wg6fqvpi28pi-xrdp.conf/sesman.ini'
       For full logs, run:
         nix log /nix/store/bklkiz5d53y95qby0r5pqd7srh2dd5zh-xrdp.conf.drv
error: 1 dependencies of derivation '/nix/store/m92j2n5y4g1hbpd4qafrfyv4z5pn13rs-unit-xrdp-sesman.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/sm21qfxbyj0mdys57ddgxjmx4jkf02kq-unit-xrdp.service.drv' failed to build

@drupol
Copy link
Contributor

drupol commented Mar 23, 2025

Damn, my bad. Going to fix this quickly now.

@spiage
Copy link

spiage commented Mar 23, 2025

root in /etc/nixos
❯ cat /nix/store/ly8sl0fwhg2pc87f12k1wg6fqvpi28pi-xrdp.conf/sesman.ini

root in /etc/nixos

@SuperSandro2000
Copy link
Member Author

Damn, I did a mistake in my testing. Can you take a look at #392512 ? I tested it locally and made sure I didn't do the same mistake again :P

@spiage
Copy link

spiage commented Mar 23, 2025

There is no issues on my system
#392512 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants