Skip to content

appium-inspector: 2024.12.1 -> 2025.3.1#391819

Merged
donovanglover merged 2 commits intoNixOS:masterfrom
NyCodeGHG:appium-inspector
Mar 31, 2025
Merged

appium-inspector: 2024.12.1 -> 2025.3.1#391819
donovanglover merged 2 commits intoNixOS:masterfrom
NyCodeGHG:appium-inspector

Conversation

@NyCodeGHG
Copy link
Member

Diff: appium/appium-inspector@v2024.12.1...v2025.3.1
Changelog: https://github.com/appium/appium-inspector/releases/tag/v2025.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 21, 2025
@donovanglover
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391819

Logs: https://github.com/donovanglover/nixpkgs-review-gha/actions/runs/14021491265


x86_64-linux

✅ 1 package built:
  • appium-inspector

aarch64-linux

✅ 1 package built:
  • appium-inspector

x86_64-darwin

❌ 1 package failed to build:
  • appium-inspector

aarch64-darwin

❌ 1 package failed to build:
  • appium-inspector

@donovanglover
Copy link
Member

Relevant part of logs:

appium-inspector>   ⨯ open /private/tmp/nix-build-appium-inspector-2025.3.1.drv-0/source/release/mac/Electron.app/Contents/Frameworks/Electron Helper (GPU).app/Contents/Info.plist: permission denied
appium-inspector>   ⨯ /private/tmp/nix-build-appium-inspector-2025.3.1.drv-0/source/node_modules/app-builder-bin/mac/app-builder_amd64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
appium-inspector> Exit code:
appium-inspector> 1  failedTask=build stackTrace=Error: /private/tmp/nix-build-appium-inspector-2025.3.1.drv-0/source/node_modules/app-builder-bin/mac/app-builder_amd64 process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
appium-inspector> Exit code:
appium-inspector> 1
appium-inspector>     at ChildProcess.<anonymous> (/private/tmp/nix-build-appium-inspector-2025.3.1.drv-0/source/node_modules/builder-util/src/util.ts:255:14)
appium-inspector>     at Object.onceWrapper (node:events:633:26)
appium-inspector>     at ChildProcess.emit (node:events:518:28)
appium-inspector>     at maybeClose (node:internal/child_process:1101:16)
appium-inspector>     at Socket.<anonymous> (node:internal/child_process:456:11)
appium-inspector>     at Socket.emit (node:events:518:28)
appium-inspector>     at Pipe.<anonymous> (node:net:351:12)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 23, 2025
@NyCodeGHG
Copy link
Member Author

the appium-inspector package only supports linux as a platform, not sure why nixpkgs-review-gha tries to build it on darwin.

@donovanglover
Copy link
Member

Try changing inherit (electron.meta) platforms; to platforms = lib.platforms.linux; (ofborg tries to build on darwin too)

@NyCodeGHG
Copy link
Member Author

Oh I see what the problem is, electron_34.meta.platforms evaluates to different platforms, depending on what hostPlatform you're evaluating for.

$ nix-instantiate --eval -A electron_34.meta.platforms --system aarch64-darwin
[ "x86_64-darwin" "x86_64-linux" "armv7l-linux" "aarch64-linux" "aarch64-darwin" ]
$ nix-instantiate --eval -A electron_34.meta.platforms --system x86_64-linux
[ "aarch64-linux" "armv5tel-linux" "armv6l-linux" "armv7a-linux" "armv7l-linux" "i686-linux" "loongarch64-linux" "m68k-linux" "microblaze-linux" "microblazeel-linux" "mips-linux" "mips64-linux" "mips64el-linux" "mipsel-linux" "powerpc64-linux" "powerpc64le-linux" "riscv32-linux" "riscv64-linux" "s390-linux" "s390x-linux" "x86_64-linux" ]

electron.meta.platforms evals to different values depending on which
system you eval for. This confuses hydra so we stop doing that since
this package only builds for linux anyways.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 31, 2025
@donovanglover donovanglover merged commit 0bfce96 into NixOS:master Mar 31, 2025
24 of 27 checks passed
@NyCodeGHG NyCodeGHG deleted the appium-inspector branch March 31, 2025 17:22
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 15, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants