Skip to content

python3Packages.flasgger: fix build#391322

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
oxij:pkgs/fix-flasgger
Aug 29, 2025
Merged

python3Packages.flasgger: fix build#391322
mweinelt merged 1 commit intoNixOS:stagingfrom
oxij:pkgs/fix-flasgger

Conversation

@oxij
Copy link
Member

@oxij oxij commented Mar 19, 2025 •
edited
Loading

6620964 updated the version without updating the hash and patches.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 19, 2025
@oxij
python3Packages.flasgger: fix build
9425abc 
6620964 updated the version without
updating the hash.

Also, both patches appear to be already applied.
@oxij oxij force-pushed the pkgs/fix-flasgger branch 2 times, most recently from 630aa47 to 9425abc Compare March 19, 2025 17:25
@oxij oxij changed the title python3Packages.flasgger: fix hash python3Packages.flasgger: fix build Mar 19, 2025
@oxij
Copy link
Member Author

oxij commented Mar 19, 2025

pylint builds and passes its tests on top of this, so this is probably fine.

@oxij
Copy link
Member Author

oxij commented Mar 20, 2025

Actually, what is the policy for changes like this? It is a mass-rebuild, but the current state on master is inconsistent (i.e. hydra is, technically, cache-poisoned at the moment) and broken.

So, does this go to master? To staging?

@oxij oxij requested a review from mweinelt March 20, 2025 12:18
@oxij oxij changed the base branch from master to staging March 20, 2025 12:30
@oxij
Copy link
Member Author

oxij commented Mar 20, 2025

After some though, I decided to assume it should be staging anyway and switched the base.

@oxij oxij mentioned this pull request Mar 31, 2025
Merged
@oneingan
Copy link
Contributor

oneingan commented Jul 21, 2025

i get hit by this. any news?

@3541
Copy link

3541 commented Aug 29, 2025

Also just got hit by this. Would be excellent to get it merged.

@mweinelt mweinelt merged commit 19c8f8a into NixOS:staging Aug 29, 2025
51 checks passed
@dotlambda dotlambda mentioned this pull request Aug 30, 2025
Merged
13 tasks
dotlambda
dotlambda reviewed Aug 30, 2025
View reviewed changes
pkgs/development/python-modules/flasgger/default.nix
};

patches = [
(fetchpatch {
Copy link
Member

@dotlambda dotlambda Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchpatch should have been removed from inputs (done in #438471)

Copy link
Member

@mweinelt mweinelt Aug 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally CI would give that feedback. Wondering if deadnix is ready for that.

@NixOS/nixpkgs-ci

Copy link
Contributor

@wolfgangwalther wolfgangwalther Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I polished up my local experimentation branch for adding nixf-diagnose to treefmt in #438559. This would be the way forward, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oxij @oneingan @3541 @mweinelt @dotlambda @wolfgangwalther