-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
vimPlugins: inherit lua & node packages before overrides #390702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| { | ||
| lib, | ||
| buildVimPlugin, | ||
| buildNeovimPlugin, | ||
| nodePackages, | ||
| neovim-unwrapped, | ||
| }: | ||
| let | ||
| luaPackages = neovim-unwrapped.lua.pkgs; | ||
| in | ||
| self: super: | ||
| ( | ||
| let | ||
| nodePackageNames = [ | ||
| "coc-cmake" | ||
| "coc-docker" | ||
| "coc-emmet" | ||
| "coc-eslint" | ||
| "coc-explorer" | ||
| "coc-flutter" | ||
| "coc-git" | ||
| "coc-go" | ||
| "coc-haxe" | ||
| "coc-highlight" | ||
| "coc-html" | ||
| "coc-java" | ||
| "coc-jest" | ||
| "coc-json" | ||
| "coc-lists" | ||
| "coc-ltex" | ||
| "coc-markdownlint" | ||
| "coc-pairs" | ||
| "coc-prettier" | ||
| "coc-r-lsp" | ||
| "coc-rls" | ||
| "coc-rust-analyzer" | ||
| "coc-sh" | ||
| "coc-smartf" | ||
| "coc-snippets" | ||
| "coc-solargraph" | ||
| "coc-spell-checker" | ||
| "coc-sqlfluff" | ||
| "coc-stylelint" | ||
| "coc-sumneko-lua" | ||
| "coc-tabnine" | ||
| "coc-texlab" | ||
| "coc-tsserver" | ||
| "coc-ultisnips" | ||
| "coc-vetur" | ||
| "coc-vimlsp" | ||
| "coc-vimtex" | ||
| "coc-wxml" | ||
| "coc-yaml" | ||
| "coc-yank" | ||
| ]; | ||
| nodePackage2VimPackage = | ||
| name: | ||
| buildVimPlugin { | ||
| pname = name; | ||
| inherit (nodePackages.${name}) version meta; | ||
| src = "${nodePackages.${name}}/lib/node_modules/${name}"; | ||
| }; | ||
| in | ||
| lib.genAttrs nodePackageNames nodePackage2VimPackage | ||
| ) | ||
| // ( | ||
| let | ||
| luarocksPackageNames = [ | ||
| "fidget-nvim" | ||
| "gitsigns-nvim" | ||
| "image-nvim" | ||
| "lsp-progress-nvim" | ||
| "lualine-nvim" | ||
| "luasnip" | ||
| "lush-nvim" | ||
| "lz-n" | ||
| "lze" | ||
| "lzextras" | ||
| "lzn-auto-require" | ||
| "middleclass" | ||
| "mini-test" | ||
| "neorg" | ||
| "neotest" | ||
| "nui-nvim" | ||
| "nvim-cmp" | ||
| "nvim-nio" | ||
| "nvim-web-devicons" | ||
| "oil-nvim" | ||
| "orgmode" | ||
| "papis-nvim" | ||
| "rest-nvim" | ||
| "rocks-config-nvim" | ||
| "rtp-nvim" | ||
| "telescope-manix" | ||
| "telescope-nvim" | ||
| ]; | ||
| toVimPackage = | ||
| name: | ||
| buildNeovimPlugin { | ||
| luaAttr = luaPackages.${name}; | ||
| }; | ||
| in | ||
| lib.genAttrs luarocksPackageNames toVimPackage | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main driver for using
buildNeovimPluginis to not have to add dependencies. Could this have been deleted instead ? same remark for the rest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nixvim's update has been blocked for a while because these overrides were no longer being applied (they we're being silently shadowed by the luaPackages-based plugins). So at least currently, most of them are still needed.
I agree, ideally
buildNeovimPluginand/ortoVimPackagewould correctly propagate the underlying lua package's dependencies, however it seems like that isn't currently happening.It's also possible that the dependencies are being propagated, but there is an issue in nixvim's combine-plugins impl. IIRC we only saw errors when combine-pluigins was being used.
Either way, overrides shouldn't be silently ignored, and this PR fixes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at nixvim's impl, that may be the case. It looks like we explicitly flat-map plugins and their
dependenciesbut don't consider things likepropagatedBuildInputs.https://github.com/nix-community/nixvim/blob/33097dcf776d1fad0ff3842096c4e3546312f251/modules/top-level/output.nix#L209-L215