[WIP] thunderbird: pass less non-standard flags#38943
Closed
[WIP] thunderbird: pass less non-standard flags#38943
Conversation
Contributor
|
This would not build for me. I've pushed two new commits on top of it that get it building and basically working: https://github.com/jerith666/nixpkgs/tree/thunderbird-config-flags Only issue I've noticed is that pushing the "play" button in the preferences dialog to test the new-mail sound doesn't work. But I'm not sure it did before those changes either. |
Contributor
|
Oh, also: the test failure looks like this: |
Contributor
|
I've updated my fork of this with a merge that resolves the conflicts: jerith666@9ee0173 |
Member
Author
|
Going to pull that; thanks! |
10 tasks
Member
Author
|
Closing in favor of #55026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite to #36449. Not tested yet.