stdenv: topological sorting of dependencies#388767
Closed
ConnorBaker wants to merge 3 commits intoNixOS:stagingfrom
Closed
stdenv: topological sorting of dependencies#388767ConnorBaker wants to merge 3 commits intoNixOS:stagingfrom
ConnorBaker wants to merge 3 commits intoNixOS:stagingfrom
Conversation
The following commit will add a way to prepend, so this makes the choice explicit. Co-authored-by: Connor Baker <ConnorBaker01@gmail.com>
This would be changing from a "preorder traversal" to a "postorder traversal". We need to *prepend* to `_PATH` now so that shallower entries take priority. Other appends that should be prepends will be fixed in the following commits. Co-authored-by: Connor Baker <ConnorBaker01@gmail.com>
…etup hook This will affect the path, and anything else should be harmless. I do wonder why this is needed at all with the wrapper scripts doing their own PATHs however. Co-authored-by: Connor Baker <ConnorBaker01@gmail.com>
github-actions
bot
added
6.topic: python
wegank
added
the
2.status: merge conflict
Contributor
Author
|
I don't have the energy to push this at the moment so I'm closing it. It's still a problem! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #31414.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.